GH-47559: [Python] Fix missing argument in pyarrow fs #47497

TennyZhuang · 2025-09-04T09:40:53Z

Rationale for this change

Fix a syntax error in Python. The argument is required.

What changes are included in this PR?

Fix a syntax error in pyarrow fs

Are these changes tested?

Yes

Are there any user-facing changes?

No

GitHub Issue: [Python] missing required argument when calling pyarrow FSSpecHandler delete_root_dir_contents #47559

github-actions · 2025-09-04T09:41:34Z

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

pitrou · 2025-09-04T14:46:41Z

Two things:

This is not a minor change as it's actually a bugfix, can you please open an issue for it?
Can you also add a test to exercise this codepath? (obviously it wasn't tested before :-))

github-actions · 2025-09-13T13:48:56Z

⚠️ GitHub issue #47559 has been automatically assigned in GitHub to PR creator.

TennyZhuang · 2025-09-14T15:08:21Z

@pitrou Hi, I've created the issue and added a test.

python/pyarrow/fs.py

pitrou · 2025-09-18T07:49:42Z

@TennyZhuang It appears the test fails on at least some CI platforms, can you look at that?

TennyZhuang · 2025-09-28T08:45:34Z

@pitrou The tests passed

raulcd · 2025-09-29T08:01:32Z

@github-actions crossbow submit -g python

github-actions · 2025-09-29T08:04:29Z

Revision: d955ff14cc5f8f4a831a6894499b7a6a1129028a

Submitted crossbow builds: ursacomputing/crossbow @ actions-4fcc94c766

Task	Status
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest-numpy-latest
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-latest-numpy-1.26
test-conda-python-3.11-pandas-latest-numpy-latest
test-conda-python-3.11-pandas-nightly-numpy-nightly
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.12-cpython-debug
test-conda-python-3.13
test-conda-python-3.9
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5
test-conda-python-emscripten
test-cuda-python-ubuntu-22.04-cuda-11.7.1
test-debian-12-python-3-amd64
test-debian-12-python-3-i386
test-fedora-42-python-3
test-ubuntu-22.04-python-3
test-ubuntu-22.04-python-313-freethreading
test-ubuntu-24.04-python-3

TennyZhuang · 2025-09-29T13:47:10Z

I cannot determine from the logs whether these failed CI Pipelines are related to my changes.

raulcd

Some of the CI failures have been fixed in main, could you rebase please? so we can get a clean CI
Thanks!

A syntax error

TennyZhuang · 2025-10-06T17:15:27Z

Rebased and force updated

raulcd · 2025-10-10T14:58:49Z

@github-actions crossbow submit -g python

github-actions · 2025-10-10T15:01:47Z

Revision: aa12f68

Submitted crossbow builds: ursacomputing/crossbow @ actions-4433b8ae9b

Task	Status
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
test-conda-python-3.10
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-1.3.4-numpy-1.21.2
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-latest-numpy-latest
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.12-cpython-debug
test-conda-python-3.12-pandas-latest-numpy-1.26
test-conda-python-3.12-pandas-latest-numpy-latest
test-conda-python-3.13
test-conda-python-3.13-pandas-nightly-numpy-nightly
test-conda-python-3.13-pandas-upstream_devel-numpy-nightly
test-conda-python-emscripten
test-cuda-python-ubuntu-22.04-cuda-11.7.1
test-debian-12-python-3-amd64
test-debian-12-python-3-i386
test-fedora-42-python-3
test-ubuntu-22.04-python-3
test-ubuntu-22.04-python-313-freethreading
test-ubuntu-24.04-python-3

TennyZhuang · 2025-10-11T12:53:33Z

It seems the CI error is unrelated to my PR. Can this PR be merged?

raulcd

LGTM

AlenkaF

Thank you @TennyZhuang!

raulcd · 2025-10-13T07:49:53Z

Thanks for the PR @TennyZhuang

conbench-apache-arrow · 2025-10-13T15:51:14Z

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b8eed8c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

…7497) ### Rationale for this change Fix a syntax error in Python. The argument is required. ### What changes are included in this PR? * Fix a syntax error in pyarrow fs ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#47559 Authored-by: TennyZhuang <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>

TennyZhuang requested review from AlenkaF, raulcd and rok as code owners September 4, 2025 09:40

github-actions bot added the awaiting review Awaiting review label Sep 4, 2025

TennyZhuang changed the title ~~[Python] Fix missing argument in pyarrow fs~~ MINOR: [Python] Fix missing argument in pyarrow fs Sep 4, 2025

TennyZhuang changed the title ~~MINOR: [Python] Fix missing argument in pyarrow fs~~ GH-47559: [Python] Fix missing argument in pyarrow fs Sep 13, 2025

github-actions bot added the Component: Python label Sep 13, 2025

pitrou reviewed Sep 15, 2025

View reviewed changes

python/pyarrow/fs.py Outdated Show resolved Hide resolved

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 15, 2025

raulcd reviewed Oct 6, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 6, 2025

TennyZhuang added 8 commits October 7, 2025 01:07

[Python] Fix missing argument in pyarrow fs

05354ee

A syntax error

test delete_root_dir_contents

044d9f7

update test

76e814a

remove redundent codes

f810150

use False as argument

ef612db

format codes

0a1a0ba

fix lint

077e63b

fix test

351c066

TennyZhuang added 3 commits October 7, 2025 01:07

chore(ci): trigger pipeline

ac3bf58

fix test

11262c1

fix test

aa12f68

TennyZhuang force-pushed the patch-1 branch from d955ff1 to aa12f68 Compare October 6, 2025 17:08

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 6, 2025

raulcd approved these changes Oct 12, 2025

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 12, 2025

AlenkaF approved these changes Oct 13, 2025

View reviewed changes

raulcd merged commit b8eed8c into apache:main Oct 13, 2025
15 checks passed

raulcd removed the awaiting merge Awaiting merge label Oct 13, 2025

raulcd mentioned this pull request Oct 13, 2025

[Python] missing required argument when calling pyarrow FSSpecHandler delete_root_dir_contents #47559

Closed

GH-47559: [Python] Fix missing argument in pyarrow fs #47497

GH-47559: [Python] Fix missing argument in pyarrow fs #47497

Conversation

TennyZhuang commented Sep 4, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

pitrou commented Sep 4, 2025

Uh oh!

github-actions bot commented Sep 13, 2025

Uh oh!

TennyZhuang commented Sep 14, 2025

Uh oh!

Uh oh!

pitrou commented Sep 18, 2025

Uh oh!

TennyZhuang commented Sep 28, 2025

Uh oh!

raulcd commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

TennyZhuang commented Sep 29, 2025

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

TennyZhuang commented Oct 6, 2025

Uh oh!

raulcd commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

TennyZhuang commented Oct 11, 2025

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

AlenkaF left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

raulcd commented Oct 13, 2025

Uh oh!

conbench-apache-arrow bot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TennyZhuang commented Sep 4, 2025 •

edited by github-actions bot

Loading