Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Jun 17, 2025

Rationale for this change

Current system requirements is outdated and was not updated to match the CMake update on:

While fixing the above it was noted that there were still other pending references on some of our codebase (docs + minor CMake)

What changes are included in this PR?

Update:

  • R system requirements to CMake >= 3.25
  • Build docs to refer to 3.25
  • Update a couple of CMake references

Are these changes tested?

CI and Archery has been exercised, no new tests are required.

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #46831 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 17, 2025
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raulcd raulcd changed the title GH-46831: [R] Update SystemRequirements with required CMake >= 3.25 GH-46831: [R] Update SystemRequirements with required CMake >= 3.25 and docs/building.rst Jun 17, 2025
@thisisnic
Copy link
Member

thisisnic commented Jun 17, 2025

Let's also update the docs: https://github.com/apache/arrow/blob/main/docs/source/developers/cpp/building.rst?plain=1#L454

Good point @assignUser. Also, here are a few other places we refer to 3.16:

function(build_azure_sdk)
if(CMAKE_VERSION VERSION_LESS 3.22)
# We can't disable installing Azure SDK for C++ by
# "set_property(DIRECTORY ${azure_sdk_SOURCE_DIR} PROPERTY
# EXCLUDE_FROM_ALL TRUE)" with CMake 3.16.
#
# At least CMake 3.22 on Ubuntu 22.04 works. So we use 3.22
# here. We may be able to use more earlier version here.
message(FATAL_ERROR "Building Azure SDK for C++ requires at least CMake 3.22. "
"(At least we can't use CMake 3.16)")

def build_requirements(self):
if Version(self.version) >= "13.0.0":
self.tool_requires("cmake/[>=3.16 <4]")

cmake_minimum_required(VERSION 3.16)

@raulcd
Copy link
Member Author

raulcd commented Jun 20, 2025

@github-actions crossbow submit -g conan example-cpp-minimal-*

@raulcd raulcd changed the title GH-46831: [R] Update SystemRequirements with required CMake >= 3.25 and docs/building.rst GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) Jun 20, 2025
@github-actions
Copy link

Revision: f0310e6

Submitted crossbow builds: ursacomputing/crossbow @ actions-5c4d9c0865

Task Status
conan-maximum GitHub Actions
conan-minimum GitHub Actions
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Jun 20, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jun 20, 2025
@raulcd raulcd requested review from AlenkaF and rok as code owners June 20, 2025 08:51
@github-actions github-actions bot added Component: Python awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 20, 2025
@raulcd raulcd changed the title GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) Jun 20, 2025
@raulcd raulcd requested a review from kou June 20, 2025 10:35
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 20, 2025
@kou kou merged commit 6822857 into apache:main Jun 20, 2025
36 of 37 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jun 20, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6822857.

There were 119 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

raulcd pushed a commit that referenced this pull request Jun 23, 2025
…Make (#46880)

### Rationale for this change

#46834 required CMake 3.25 or later for an example CMake project.

### What changes are included in this PR?

Don't build the example CMake project with CMake < 3.25 in package verification. Amazon Linux 2023, CentOS  7 and Ubuntu 22.04 don't provide CMake 3.25 or later.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #46879

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants