-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) #46834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
assignUser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update the docs: https://github.com/apache/arrow/blob/main/docs/source/developers/cpp/building.rst?plain=1#L454
Good point @assignUser. Also, here are a few other places we refer to 3.16: arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake Lines 5305 to 5314 in 639201b
arrow/ci/conan/all/conanfile.py Lines 270 to 272 in 639201b
|
|
@github-actions crossbow submit -g conan example-cpp-minimal-* |
|
Revision: f0310e6 Submitted crossbow builds: ursacomputing/crossbow @ actions-5c4d9c0865
|
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6822857. There were 119 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…Make (#46880) ### Rationale for this change #46834 required CMake 3.25 or later for an example CMake project. ### What changes are included in this PR? Don't build the example CMake project with CMake < 3.25 in package verification. Amazon Linux 2023, CentOS 7 and Ubuntu 22.04 don't provide CMake 3.25 or later. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46879 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Rationale for this change
Current system requirements is outdated and was not updated to match the CMake update on:
While fixing the above it was noted that there were still other pending references on some of our codebase (docs + minor CMake)
What changes are included in this PR?
Update:
Are these changes tested?
CI and Archery has been exercised, no new tests are required.
Are there any user-facing changes?
No