Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jun 9, 2025

Rationale for this change

#45459 introduced RapidJSON dependency to Parquet support. Conan recipe enables Parquet by default but it doesn't enable RapidJSON by default. So we can't find RapidJSON.

What changes are included in this PR?

Disable Parquet by default.

We should report "Parquet support requires RapidJSON support" to Conan when we release 21.0.0.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Jun 9, 2025

@github-actions crossbow submit -g conan

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Revision: 25cd22b

Submitted crossbow builds: ursacomputing/crossbow @ actions-16c23e405a

Task Status
conan-maximum GitHub Actions
conan-minimum GitHub Actions

@hiroyuki-sato
Copy link
Collaborator

LGTM👍 Thanks!

@kou kou merged commit 5633582 into apache:main Jun 9, 2025
11 of 13 checks passed
@kou kou deleted the conan-minimum branch June 9, 2025 20:32
@kou kou removed the awaiting committer review Awaiting committer review label Jun 9, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5633582.

There were 66 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them.

alinaliBQ pushed a commit to Bit-Quill/arrow that referenced this pull request Jun 17, 2025
### Rationale for this change

apache#45459 introduced RapidJSON dependency to Parquet support. Conan recipe enables Parquet by default but it doesn't enable RapidJSON by default. So we can't find RapidJSON.

### What changes are included in this PR?

Disable Parquet by default.

We should report "Parquet support requires RapidJSON support" to Conan when we release 21.0.0.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#46736

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants