Skip to content

GH-46699: [CI][Dev] fix shellcheck errors in the ci/scripts/cpp_test.sh #46700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Jun 5, 2025
+11 −10
Merged

GH-46699: [CI][Dev] fix shellcheck errors in the ci/scripts/cpp_test.sh #46700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ repos:
?^ci/scripts/c_glib_build\.sh$|
?^ci/scripts/c_glib_test\.sh$|
?^ci/scripts/conan_setup\.sh$|
?^ci/scripts/cpp_test\.sh$|
?^ci/scripts/csharp_build\.sh$|
?^ci/scripts/csharp_pack\.sh$|
?^ci/scripts/download_tz_database\.sh$|
Expand Down
20 changes: 10 additions & 10 deletions ci/scripts/cpp_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

set -ex

if [[ $# < 2 ]]; then
if [[ $# -lt 2 ]]; then
echo "Usage: $0 <Arrow dir> <build dir> [ctest args ...]"
exit 1
fi
Expand Down Expand Up @@ -84,7 +84,7 @@ if [ "${ARROW_EMSCRIPTEN:-OFF}" = "ON" ]; then
n_jobs=1 # avoid spurious fails on emscripten due to loading too many big executables
fi

pushd ${build_dir}
pushd "${build_dir}"

if [ -z "${PYTHON}" ] && ! which python > /dev/null 2>&1; then
export PYTHON="${PYTHON:-python3}"
Expand All @@ -100,15 +100,15 @@ else
ctest \
--label-regex unittest \
--output-on-failure \
--parallel ${n_jobs} \
--parallel "${n_jobs}" \
--repeat until-pass:3 \
--timeout ${ARROW_CTEST_TIMEOUT:-300} \
--timeout "${ARROW_CTEST_TIMEOUT:-300}" \
"${ctest_options[@]}" \
"$@"
fi

if [ "${ARROW_BUILD_EXAMPLES}" == "ON" ]; then
examples=$(find ${binary_output_dir} -executable -name "*example")
examples=$(find "${binary_output_dir}" -executable -name "*example")
if [ "${examples}" == "" ]; then
echo "=================="
echo "No examples found!"
Expand All @@ -126,12 +126,12 @@ fi

if [ "${ARROW_FUZZING}" == "ON" ]; then
# Fuzzing regression tests
${binary_output_dir}/arrow-ipc-stream-fuzz ${ARROW_TEST_DATA}/arrow-ipc-stream/crash-*
${binary_output_dir}/arrow-ipc-stream-fuzz ${ARROW_TEST_DATA}/arrow-ipc-stream/*-testcase-*
${binary_output_dir}/arrow-ipc-file-fuzz ${ARROW_TEST_DATA}/arrow-ipc-file/*-testcase-*
${binary_output_dir}/arrow-ipc-tensor-stream-fuzz ${ARROW_TEST_DATA}/arrow-ipc-tensor-stream/*-testcase-*
"${binary_output_dir}/arrow-ipc-stream-fuzz" "${ARROW_TEST_DATA}"/arrow-ipc-stream/crash-*
"${binary_output_dir}/arrow-ipc-stream-fuzz" "${ARROW_TEST_DATA}"/arrow-ipc-stream/*-testcase-*
"${binary_output_dir}/arrow-ipc-file-fuzz" "${ARROW_TEST_DATA}"/arrow-ipc-file/*-testcase-*
"${binary_output_dir}/arrow-ipc-tensor-stream-fuzz" "${ARROW_TEST_DATA}"/arrow-ipc-tensor-stream/*-testcase-*
if [ "${ARROW_PARQUET}" == "ON" ]; then
${binary_output_dir}/parquet-arrow-fuzz ${ARROW_TEST_DATA}/parquet/fuzzing/*-testcase-*
"${binary_output_dir}/parquet-arrow-fuzz" "${ARROW_TEST_DATA}"/parquet/fuzzing/*-testcase-*
fi
fi

Expand Down
Loading