Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Jun 3, 2025

Rationale for this change

Addresses #46180 (comment). One of three PRs to resolve #46439.

What changes are included in this PR?

  • Remove unneeded namespace prefix in test_util_internal.h.

Are these changes tested?

Yes. Impacted tests still pass.

Are there any user-facing changes?

No.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 58b8a6f into apache:main Jun 3, 2025
33 of 39 checks passed
@kou kou removed the awaiting review Awaiting review label Jun 3, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 3, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 58b8a6f.

There were 75 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Address post-merge review comments in PR exposing {Array,...}FromJSON helpers in public API

2 participants