Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jun 3, 2025

Rationale for this change

There is a typo.

FYI: This is not a critical because this typo exists in code that is only executed in an error case.

What changes are included in this PR?

Fix a typo.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

⚠️ GitHub issue #46688 has been automatically assigned in GitHub to PR creator.

@hiroyuki-sato
Copy link
Collaborator

+1 (I can't test on my local machine yet.)

Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit b119f5e into apache:main Jun 3, 2025
9 of 10 checks passed
@kou kou deleted the ruby-typo branch June 3, 2025 21:32
@kou kou removed the awaiting committer review Awaiting committer review label Jun 3, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b119f5e.

There were 81 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants