GH-31603: [C++] Add SecureString implementation to arrow/util/#46626

Merged

pitrou merged 22 commits intoapache:mainfrom

EnricoMi:secure-string-util

Jun 9, 2025

Commits on Jun 9, 2025

Add SecureString implementation to arrow/util/

EnricoMi
authored and
pitrou
committed
Fix import for memset_s, improve for loops in tests

EnricoMi
and
pitrou
committed
Address code review comments

EnricoMi
authored and
pitrou
committed
Test secure SecureString deconstruction

EnricoMi
authored and
pitrou
committed
Test correctness of AssertSecurelyCleared

EnricoMi
authored and
pitrou
committed
Rename SecureString argument to other

EnricoMi
authored and
pitrou
committed
Move std::move into secure_move, assert string ptr

EnricoMi
authored and
pitrou
committed
Add comments, fix linting

EnricoMi
authored and
pitrou
committed
Improve assertions

EnricoMi
authored and
pitrou
committed
Use testing::AssertionResult rather than capturing assertions through TestPartResultReporterInterface

EnricoMi
authored and
pitrou
committed
Expect string buffers larger than requested size

EnricoMi
authored and
pitrou
committed
Handle string buffers larger than init size

EnricoMi
authored and
pitrou
committed
Don't access deallocated memory in ASAN / Valgrind mode

EnricoMi
authored and
pitrou
committed
Fix SecureClear for non-local strings, stabalize mem assertions

EnricoMi
authored and
pitrou
committed
Avoid assigning short string to long string in test

EnricoMi
authored and
pitrou
committed
Fix memory issues in tests

EnricoMi
authored and
pitrou
committed
Improve comments

EnricoMi
authored and
pitrou
committed
Apply code review comments

EnricoMi
authored and
pitrou
committed
Move SecureClear(std::string*) up in source file as well

EnricoMi
authored and
pitrou
committed
Undefine macro after use
pitrou
committed
Fix and enhance Construct test
pitrou
committed
Also skip deallocated area tests on Thread Sanitizer
pitrou
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH-31603: [C++] Add SecureString implementation to arrow/util/#46626

GH-31603: [C++] Add SecureString implementation to arrow/util/#46626
pitrou merged 22 commits intoapache:mainfrom
EnricoMi:secure-string-util

Commits on Jun 9, 2025

Add SecureString implementation to arrow/util/

Fix import for memset_s, improve for loops in tests

Address code review comments

Test secure SecureString deconstruction

Test correctness of AssertSecurelyCleared

Rename SecureString argument to other

Move std::move into secure_move, assert string ptr

Add comments, fix linting

Improve assertions

Use testing::AssertionResult rather than capturing assertions through TestPartResultReporterInterface

Expect string buffers larger than requested size

Handle string buffers larger than init size

Don't access deallocated memory in ASAN / Valgrind mode

Fix SecureClear for non-local strings, stabalize mem assertions

Avoid assigning short string to long string in test

Fix memory issues in tests

Improve comments

Apply code review comments

Move SecureClear(std::string*) up in source file as well

Undefine macro after use

Fix and enhance Construct test

Also skip deallocated area tests on Thread Sanitizer

GH-31603: [C++] Add SecureString implementation to arrow/util/#46626pitrou merged 22 commits intoapache:mainapache/arrow:mainfrom EnricoMi:secure-string-utilEnricoMi/arrow:secure-string-utilCopy head branch name to clipboard

Commits

Commits on Jun 9, 2025

GH-31603: [C++] Add SecureString implementation to arrow/util/#46626
pitrou merged 22 commits intoapache:mainfrom
EnricoMi:secure-string-util