-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[EXP] GH-44792: [C++] Require C++20 #45445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
394fc03 to
68d69e2
Compare
|
@github-actions crossbow submit -g cpp -g python |
This comment was marked as outdated.
This comment was marked as outdated.
68d69e2 to
948c651
Compare
948c651 to
318b69a
Compare
|
@github-actions crossbow submit -g cpp -g python -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g linux -g r |
This comment was marked as outdated.
This comment was marked as outdated.
|
So, it seems two main issues may be blocking this:
Edit: a couple R builds also seem to have a non-C++20 compliant stdlib. @kou What is our policy for Almalinux and CentOS support? |
|
We can use
|
|
I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency). |
Right. FYI: There is a related issue: #44792 |
1244c29 to
bc7811a
Compare
|
@github-actions crossbow submit centos* |
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bc7811a to
581f307
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheelcp313* |
|
@github-actions crossbow submit -g r |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related? |
|
@pitrou They are not related, they all show the same error that also shows up in the nightly builds: |
Relatedly, is someone trying to fix them? Is there an issue open? |
Co-authored-by: Sutou Kouhei <[email protected]>
|
@github-actions crossbow submit -g cpp -g python |
|
@github-actions crossbow submit wheelcp313* |
|
Revision: a711a38 Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54 |
|
Revision: a711a38 Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237 |
|
@github-actions crossbow submit -g linux |
|
Revision: a711a38 Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a |
|
@github-actions crossbow submit -g r |
|
Revision: a711a38 Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b |
|
This PR was getting unwieldy, I opened a new fresh one at #48414 |
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?