Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Feb 6, 2025

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions
Copy link

github-actions bot commented Feb 6, 2025

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou
Copy link
Member Author

pitrou commented Feb 6, 2025

@github-actions crossbow submit -g cpp -g python

@github-actions

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Feb 6, 2025

@github-actions crossbow submit -g cpp -g python -g wheel

@github-actions

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Feb 6, 2025

@github-actions crossbow submit -g linux -g r

@github-actions

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Feb 6, 2025

So, it seems two main issues may be blocking this:

  1. The AWS SDK fails to build ("Could not determine support for atomic operations")
  2. CentOS 8 and Almalinux 8 do not have a C++20 compliant C++ stdlib (by default)

Edit: a couple R builds also seem to have a non-C++20 compliant stdlib.

@kou What is our policy for Almalinux and CentOS support?

@kou
Copy link
Member

kou commented Feb 7, 2025

We can use gcc-toolset-{9,10,11,12,13,14} on AlmaLinux 8 and CentOS Stream 8 if we needed. For example, AlmaLinux 9 uses gcc-toolset-12:


@pitrou
Copy link
Member Author

pitrou commented Feb 7, 2025

I see, thanks. So there are probably no insurmountable issues against switching to C++20. Of course, this will have to be discussed on the ML at some point (and there's no urgency).

@kou
Copy link
Member

kou commented Feb 7, 2025

this will have to be discussed on the ML at some point

Right.

FYI: There is a related issue: #44792

@pitrou pitrou changed the title EXP: [C++] Require C++20 [EXP] GH-44792: [C++] Require C++20 Feb 27, 2025
@pitrou pitrou force-pushed the cxx20-experiment branch 2 times, most recently from 1244c29 to bc7811a Compare March 18, 2025 11:15
@pitrou
Copy link
Member Author

pitrou commented Mar 18, 2025

@github-actions crossbow submit centos*

@pitrou
Copy link
Member Author

pitrou commented Mar 18, 2025

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou pitrou force-pushed the cxx20-experiment branch from bc7811a to 581f307 Compare March 18, 2025 11:36
@github-actions

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Apr 23, 2025

@github-actions crossbow submit wheelcp313*

@pitrou
Copy link
Member Author

pitrou commented Apr 23, 2025

@github-actions crossbow submit -g r

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Apr 23, 2025

@assignUser See R Crossbow build results just above. Can you check whether the failures are actually related?

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 24, 2025
@assignUser
Copy link
Member

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

── Error ('test-s3-minio.R:64:1'): copy files with s3 ──────────────────────────
Error: Key error: Attempted to register factory for scheme 's3' but that scheme is already registered.
Backtrace:
    ▆
 1. └─arrow::copy_files(uri_formatter("hive_dir"), td) at tests/testthat/helper-filesystems.R:173:7
 2.   └─arrow:::get_path_and_filesystem(from)
 3.     └─arrow:::get_paths_and_filesystem(x, filesystem)
 4.       └─base::lapply(x, FileSystem$from_uri)
 5.         └─arrow (local) FUN(X[[i]], ...)
 6.           └─arrow:::fs___FileSystemFromUri(uri)

@pitrou
Copy link
Member Author

pitrou commented May 5, 2025

@pitrou They are not related, they all show the same error that also shows up in the nightly builds:

Relatedly, is someone trying to fix them? Is there an issue open?

@pitrou pitrou force-pushed the cxx20-experiment branch from 41b3f1d to 16eca75 Compare May 19, 2025 12:54
@github-actions github-actions bot added awaiting change review Awaiting change review and removed Component: FlightRPC awaiting changes Awaiting changes labels May 19, 2025
@pitrou
Copy link
Member Author

pitrou commented May 19, 2025

@github-actions crossbow submit -g cpp -g python

@pitrou
Copy link
Member Author

pitrou commented May 19, 2025

@github-actions crossbow submit wheelcp313*

@github-actions
Copy link

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c72ad3e54

Task Status
wheel-macos-monterey-cp313-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313-amd64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313-arm64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-amd64 GitHub Actions
wheel-musllinux-1-2-cp313-cp313t-arm64 GitHub Actions
wheel-windows-cp313-cp313-amd64 GitHub Actions
wheel-windows-cp313-cp313t-amd64 GitHub Actions

@github-actions
Copy link

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-884015d237

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-meson GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented May 19, 2025

@github-actions crossbow submit -g linux

@github-actions
Copy link

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-43a66e208a

Task Status
almalinux-8-amd64 GitHub Actions
almalinux-8-arm64 GitHub Actions
almalinux-9-amd64 GitHub Actions
almalinux-9-arm64 GitHub Actions
amazon-linux-2023-amd64 GitHub Actions
amazon-linux-2023-arm64 GitHub Actions
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions
debian-bookworm-amd64 GitHub Actions
debian-bookworm-arm64 GitHub Actions
debian-trixie-amd64 GitHub Actions
debian-trixie-arm64 GitHub Actions
ubuntu-jammy-amd64 GitHub Actions
ubuntu-jammy-arm64 GitHub Actions
ubuntu-noble-amd64 GitHub Actions
ubuntu-noble-arm64 GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented May 19, 2025

@github-actions crossbow submit -g r

@github-actions
Copy link

Revision: a711a38

Submitted crossbow builds: ursacomputing/crossbow @ actions-3da723357b

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.2-jammy Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented Dec 9, 2025

This PR was getting unwieldy, I opened a new fresh one at #48414

@pitrou pitrou closed this Dec 9, 2025
@pitrou pitrou deleted the cxx20-experiment branch December 9, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants