Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Feb 3, 2025

Rationale for this change

It'll reach EOL on 2025-04-30.

What changes are included in this PR?

Require Node.js 20 or later.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

It'll reach EOL on 2025-04-30.
@github-actions
Copy link

github-actions bot commented Feb 3, 2025

⚠️ GitHub issue apache/arrow-js#46 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Feb 3, 2025

@github-actions crossbow submit verify-rs-source-js-*

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Unable to match any tasks for `verify-rs-source-js-*`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13103806642

@kou
Copy link
Member Author

kou commented Feb 3, 2025

@github-actions crossbow submit verify-rc-source-js-*

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Revision: d6054eb

Submitted crossbow builds: ursacomputing/crossbow @ actions-a4679b5ebe

Task Status
verify-rc-source-js-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-js-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-js-macos-amd64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions

@kou
Copy link
Member Author

kou commented Feb 3, 2025

Hmm. One integration test is crashed.

@trxcllnt @domoritz Could you take a look at this?

https://github.com/apache/arrow/actions/runs/13103799419/job/36559121055#step:11:9994

  Testing file /tmp/arrow-integration-eb15rcss/generated_nested.json
  -- Creating binary inputs
  -- Validating file
  -- Validating stream
  Traceback (most recent call last):
    File "/arrow/dev/archery/archery/integration/util.py", line 136, in run_cmd
      output = subprocess.check_output(cmd, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/opt/conda/envs/arrow/lib/python3.11/subprocess.py", line 466, in check_output
      return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/opt/conda/envs/arrow/lib/python3.11/subprocess.py", line 571, in run
      raise CalledProcessError(retcode, process.args,
  subprocess.CalledProcessError: Command '['/build/js/bin/integration.ts', '-a', '/tmp/tmp6xnzfhuw/52fee1a0_generated_nested.consumer_stream_as_file', '-j', '/tmp/arrow-integration-eb15rcss/generated_nested.json', '--mode', 'VALIDATE']' died with <Signals.SIGTRAP: 5>.
  
  During handling of the above exception, another exception occurred:
  
  Traceback (most recent call last):
    File "/arrow/dev/archery/archery/integration/runner.py", line 319, in _run_ipc_test_case
      run_binaries(producer, consumer, test_case)
    File "/arrow/dev/archery/archery/integration/runner.py", line 362, in _produce_consume
      consumer.validate(json_path, consumer_file_path)
    File "/arrow/dev/archery/archery/integration/tester_js.py", line 61, in validate
      return self._run(_VALIDATE, arrow_path, json_path, 'VALIDATE')
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/arrow/dev/archery/archery/integration/tester_js.py", line 58, in _run
      run_cmd(cmd, cwd=ARROW_JS_ROOT)
    File "/arrow/dev/archery/archery/integration/util.py", line 145, in run_cmd
      raise RuntimeError(sio.getvalue())
  RuntimeError: Command failed: /build/js/bin/integration.ts -a /tmp/tmp6xnzfhuw/52fee1a0_generated_nested.consumer_stream_as_file -j /tmp/arrow-integration-eb15rcss/generated_nested.json --mode VALIDATE
  With output:
  --------------
  
  
  #
  # Fatal error in , line 0
  # unreachable code
  #
  #
  #
  #FailureMessage Object: 0x7ffb00ff6970
  ----- Native stack trace -----
  
   1: 0x7ffb05d1cfd7  [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   2: 0x7ffb06a5791f V8_Fatal(char const*, ...) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   3: 0x7ffb0636dbb4  [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   4: 0x7ffb0636f06f v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   5: 0x7ffb0636f6c6 v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   6: 0x7ffb0675e9ab  [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   7: 0x7ffb06767508 v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   8: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
   9: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  10: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  11: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  12: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  13: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  14: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  15: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  16: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  17: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  18: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  19: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  20: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  21: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  22: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  23: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  24: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  25: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  26: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  27: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  28: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  29: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  30: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  31: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  32: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  33: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  34: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  35: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  36: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  37: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  38: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  39: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  40: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  41: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  42: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  43: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  44: 0x7ffb0676603d int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHeapObject>(unsigned char, v8::internal::SlotAccessorForHeapObject) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  45: 0x7ffb06767261 v8::internal::Deserializer<v8::internal::Isolate>::ReadData(v8::internal::Handle<v8::internal::HeapObject>, int, int) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  46: 0x7ffb067675aa v8::internal::Deserializer<v8::internal::Isolate>::ReadObject(v8::internal::SnapshotSpace) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  47: 0x7ffb06765545 int v8::internal::Deserializer<v8::internal::Isolate>::ReadSingleBytecodeData<v8::internal::SlotAccessorForHandle<v8::internal::Isolate> >(unsigned char, v8::internal::SlotAccessorForHandle<v8::internal::Isolate>) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  48: 0x7ffb06765d31 v8::internal::Deserializer<v8::internal::Isolate>::ReadObject() [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  49: 0x7ffb06769796 v8::internal::ObjectDeserializer::Deserialize() [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  50: 0x7ffb067699a1 v8::internal::ObjectDeserializer::DeserializeSharedFunctionInfo(v8::internal::Isolate*, v8::internal::SerializedCodeData const*, v8::internal::Handle<v8::internal::String>) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  51: 0x7ffb0675c3d7 v8::internal::CodeSerializer::Deserialize(v8::internal::Isolate*, v8::internal::AlignedCachedData*, v8::internal::Handle<v8::internal::String>, v8::ScriptOriginOptions, v8::internal::MaybeHandle<v8::internal::Script>) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  52: 0x7ffb06245112  [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  53: 0x7ffb062454bd v8::internal::Compiler::GetSharedFunctionInfoForScriptWithCachedData(v8::internal::Isolate*, v8::internal::Handle<v8::internal::String>, v8::internal::ScriptDetails const&, v8::internal::AlignedCachedData*, v8::ScriptCompiler::CompileOptions, v8::ScriptCompiler::NoCacheReason, v8::internal::NativesFlag) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  54: 0x7ffb061a39e6 v8::ScriptCompiler::CompileUnboundInternal(v8::Isolate*, v8::ScriptCompiler::Source*, v8::ScriptCompiler::CompileOptions, v8::ScriptCompiler::NoCacheReason) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  55: 0x7ffb05c8cb8b node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  56: 0x7ffb061e123e  [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  57: 0x7ffb061e1560 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]
  58: 0x7ffb05fa91b6  [/opt/conda/envs/arrow/bin/../lib/libnode.so.115]

@amoeba
Copy link
Member

amoeba commented Apr 11, 2025

@kou this looks very similar to an issue we've seen in the past so I don't think the failure here is directly related to the change. See my Details in #44294 (comment).

@kou
Copy link
Member Author

kou commented Apr 13, 2025

Thanks for the information!

It may be better that we handle this after repository split...
#45943

@github-actions
Copy link

⚠️ GitHub issue #45412 has no components, please add labels for components.

@kou
Copy link
Member Author

kou commented May 27, 2025

I close this. I hope that anyone completes this...

@kou kou closed this May 27, 2025
@kou kou deleted the js-drop-node-18 branch May 27, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants