ARROW-713: [C++] Fix cmake linking issue in new IPC benchmark #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jeffknupp can you change the PR title to start with ARROW-713: ? thanks |
jeffknupp
changed the title
Contributor
Author
|
@wesm updated |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
1) `parquet-cpp` does not implement filtering (predicate pushdown). Clients such as Vertica, read the statistics from the metadata and implement their own filtering based on these stats. Therefore, the read path does not require any changes. We should document that the min/max value can potentially contain NaNs. 2) I made changes to the write path to ignore the NaNs. Author: Deepak Majeti <[email protected]> Closes apache#444 from majetideepak/PARQUET-1225 and squashes the following commits: c29ede2 [Deepak Majeti] refactor code c02adb2 [Deepak Majeti] fix compiler error 1c229e2 [Deepak Majeti] fix logic for UpdateSpaced baf6f50 [Deepak Majeti] change api from NotNaN to IsNaN 3144a6a [Deepak Majeti] clang format ba44611 [Deepak Majeti] review comments and add tests 63e889b [Deepak Majeti] PARQUET-1225: NaN values may lead to incorrect filtering under certain circumstances Change-Id: Ib4085ab0c0a254ec33995c7b4cdf2f5c3d63fae2
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Fixes apache#22. Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.