MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.29 to 10.17.0 in /java #43311

danepitkin · 2024-07-17T21:39:37Z

Rationale for this change

Now that Java 8 is deprecated, we can bump checkstyle to latest version.

What changes are included in this PR?

Bump checkstyle to 10.17.0
Update checkstyle.xml to fix backwards-breaking changes
Fix new check errors

Are these changes tested?

CI

Are there any user-facing changes?

No

danepitkin · 2024-07-17T21:39:55Z

@github-actions crossbow submit -g java

github-actions · 2024-07-17T21:42:20Z

Revision: 6583c9266e9bda47f29547acea3bf21a63a062f3

Submitted crossbow builds: ursacomputing/crossbow @ actions-3d2568a501

Task	Status
java-jars
test-conda-python-3.11-spark-master
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-07-24T22:49:37Z

@danepitkin might need explicit formatting?

danepitkin · 2024-07-26T18:59:35Z

@github-actions crossbow submit -g java

github-actions · 2024-07-26T19:02:02Z

Revision: e390e0b7307b3183446126e3f7484b3b3ee001b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-83f5abdb26

Task	Status
java-jars
test-conda-python-3.11-spark-master
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

vibhatha · 2024-07-29T01:41:56Z

@github-actions crossbow submit java-jars

vibhatha · 2024-07-29T01:42:39Z

Oh probably this may need #43431

github-actions · 2024-07-29T01:44:14Z

Revision: e390e0b7307b3183446126e3f7484b3b3ee001b6

Submitted crossbow builds: ursacomputing/crossbow @ actions-0e19636c2e

Task	Status
java-jars

lidavidm · 2024-07-29T05:24:16Z

[INFO] Scanning for projects...
Error: ] Some problems were encountered while processing the POMs:
[FATAL] Non-readable POM /Users/runner/work/crossbow/crossbow/arrow/java/maven: /Users/runner/work/crossbow/crossbow/arrow/java/maven (No such file or directory) @ 
 @ 
[INFO] 0 goals, 0 executed

needs a rebase?

lidavidm · 2024-07-29T05:24:36Z

ah I thought the PR Vibhatha linked was merged already

lidavidm · 2024-07-29T05:29:40Z

Ok, now it just needs a rebase!

laurentgo · 2024-07-29T16:13:15Z

java/dev/checkstyle/checkstyle.xml

Why are we removing the property here? Wouldn't that confusion for people using Windows line separator?

Good call, I should fix this properly.

The windows build was always generating windows line separators. There was a bug in the old version of checkstyle that couldn't differentiate between lf (\n) and crlf (\r\n), so this was never caught before. checkstyle/checkstyle#4074

Fixed! I just had to update java/.gitattributes

laurentgo · 2024-07-29T21:14:11Z

java/.gitattributes

does it mean that all files are to be considerered as text files (vs binary)? Would'nt that cause issues when adding binary files (for testing for example?)

Maybe it should be * text=auto eol=lf?

Good catch. I was following the instruction from spotless.. https://github.com/diffplug/spotless/tree/main/plugin-gradle#line-endings-and-encodings-invisible-stuff

lidavidm · 2024-07-29T23:07:36Z

@github-actions crossbow submit java-jars

github-actions · 2024-07-29T23:09:49Z

Revision: 4c3f929515acc1f4e119646ec36005cecc647bd9

Submitted crossbow builds: ursacomputing/crossbow @ actions-36a3d85d67

Task	Status
java-jars

vibhatha · 2024-07-30T03:16:08Z

@lidavidm this seems to be a new failure in java-jars.

vibhatha

@danepitkin Thanks for working on this one. PR LGTM!

….0 in /java

@return

, @return, @throws, @deprecated]

…ut CRLF(\r\n) is detected.

danepitkin · 2024-07-30T13:02:39Z

@github-actions crossbow submit java-jars

github-actions · 2024-07-30T13:04:56Z

Revision: 24a762b

Submitted crossbow builds: ursacomputing/crossbow @ actions-40a559e941

Task	Status
java-jars

vibhatha · 2024-07-30T14:12:38Z

@danepitkin have we already identified the failure in java-jars? It seems like a centOS related thing?

danepitkin · 2024-07-30T14:13:55Z

Yeah, looks like CentOS 7 causing issues again!

conbench-apache-arrow · 2024-07-30T21:34:25Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 48782e7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 14 possible false positives for unstable benchmarks that are known to sometimes produce them.

….0 in /java (apache#43311) ### Rationale for this change Now that Java 8 is deprecated, we can bump checkstyle to latest version. ### What changes are included in this PR? * Bump checkstyle to 10.17.0 * Update checkstyle.xml to fix backwards-breaking changes * Fix new check errors ### Are these changes tested? CI ### Are there any user-facing changes? No Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Dane Pitkin <[email protected]>

danepitkin requested a review from lidavidm as a code owner July 17, 2024 21:39

github-actions bot added Component: Java awaiting review Awaiting review labels Jul 17, 2024

danepitkin marked this pull request as draft July 17, 2024 21:42

danepitkin mentioned this pull request Jul 17, 2024

[Java] Remove Java 8 support in Arrow v18 #38051

Closed

7 tasks

danepitkin force-pushed the danepitkin/checkstyle-10-17-0 branch from 6583c92 to 92fdef9 Compare July 24, 2024 15:50

danepitkin force-pushed the danepitkin/checkstyle-10-17-0 branch from 92fdef9 to f417a2d Compare July 26, 2024 16:09

danepitkin marked this pull request as ready for review July 26, 2024 19:12

danepitkin requested a review from vibhatha July 26, 2024 19:13

lidavidm approved these changes Jul 29, 2024

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jul 29, 2024

danepitkin force-pushed the danepitkin/checkstyle-10-17-0 branch from e390e0b to a5c2bd1 Compare July 29, 2024 13:53

laurentgo reviewed Jul 29, 2024

View reviewed changes

danepitkin requested review from assignUser, jonkeane, kou and raulcd as code owners July 29, 2024 18:09

laurentgo reviewed Jul 29, 2024

View reviewed changes

vibhatha approved these changes Jul 30, 2024

View reviewed changes

danepitkin added 15 commits July 30, 2024 09:02

MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.29 to 10.17…

82ad57d

….0 in /java

Pin maven-checkstyle-plugin to latest version

ce763d7

Use default checkstyle version 9.3

32de2b7

Delete checkstyle version pin

b8b2102

Revert maven-checkstyle-plugin version change

f820e99

Update checkstyle config

50c2f7b

(javadoc) AtclauseOrder: Block tags have to appear in the order '[@param

5f1654f

, @return, @throws, @deprecated]

(javadoc) MissingJavadocMethod: Missing a Javadoc comment.

48b9871

Remove accidental import

0d9036f

(misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), b…

fcd5c80

…ut CRLF(\r\n) is detected.

Pin checkstyle to 10.17.0

e1c85f9

Add lf newline back

3a20a9f

Disable auto crlf on windows

a8db1d3

Try .gitattributes instead

8f72c75

Use text=auto

24a762b

danepitkin force-pushed the danepitkin/checkstyle-10-17-0 branch from 4c3f929 to 24a762b Compare July 30, 2024 13:02

danepitkin merged commit 48782e7 into apache:main Jul 30, 2024

danepitkin removed the awaiting merge Awaiting merge label Jul 30, 2024

MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.29 to 10.17.0 in /java #43311

MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.29 to 10.17.0 in /java #43311

Uh oh!

Conversation

danepitkin commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

danepitkin commented Jul 17, 2024

Uh oh!

github-actions bot commented Jul 17, 2024

Uh oh!

vibhatha commented Jul 24, 2024

Uh oh!

danepitkin commented Jul 26, 2024

Uh oh!

github-actions bot commented Jul 26, 2024

Uh oh!

vibhatha commented Jul 29, 2024

Uh oh!

vibhatha commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

lidavidm commented Jul 29, 2024

Uh oh!

lidavidm commented Jul 29, 2024

Uh oh!

lidavidm commented Jul 29, 2024

Uh oh!

laurentgo Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

danepitkin Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danepitkin Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

laurentgo Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

laurentgo Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

danepitkin Jul 29, 2024

Choose a reason for hiding this comment

Uh oh!

lidavidm commented Jul 29, 2024

Uh oh!

github-actions bot commented Jul 29, 2024

Uh oh!

vibhatha commented Jul 30, 2024

Uh oh!

vibhatha left a comment

Choose a reason for hiding this comment

Uh oh!

danepitkin commented Jul 30, 2024

Uh oh!

github-actions bot commented Jul 30, 2024

Uh oh!

vibhatha commented Jul 30, 2024

Uh oh!

danepitkin commented Jul 30, 2024

Uh oh!

conbench-apache-arrow bot commented Jul 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danepitkin commented Jul 17, 2024 •

edited

Loading

danepitkin Jul 29, 2024 •

edited

Loading