-
Notifications
You must be signed in to change notification settings - Fork 4k
moved appropriate dependencies to dev dependencies #43215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ent and not in runtime to devdependencies
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
|
These are indeed runtime dependencies. |
|
@trxcllnt These only appear to be runtime dependencies of the example cli application, not the library. Most consumers of 'apache-arrow' are using it as a library, and this brings in a lot of additional unnecessary dependencies. I did a bit of inspection, and the only dependency of the library |
|
The cli isn't an example only, though. Yes, we could refactor the package to reduce download sizes. Right now we are at <10mb, though: https://packagephobia.com/result?p=apache-arrow. |
|
Actually, seems like it's only 2.9MB and the biggest one is @types/node |
|
Even if the impact is relatively small, there is no good reason for them to be there for consumers of the 'apache-arrow' library. I think it's worth the effort to either refactor, or make them into dev dependencies. |
|
I think we would have a breaking change when we remove the CLI from the public API. I am okay with that and would be happy to review a pull request. |
moved dependencies which are only required while testing and development and not in runtime to dev dependencies
dependencies which are moved:
