ARROW-686: [C++] Account for time metadata changes, add Time32 and Time64 types #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie04868f2a905c61f93b544eb86650aeb63e835bc
Change-Id: I75a0c66bca3365bafd123cb639218dc523cbb6d3
Change-Id: I2cf7a647e2429e8e3f8ad96d0b0d62ed23b5c5e9
Change-Id: I8948f74d2ff3b1e5182167b88792273e5e28e104
Member
Author
|
@xhochy I removed the copy ctors for |
xhochy
approved these changes
Mar 24, 2017
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, code looks fine only the TODO seems obsolete.
cpp/src/arrow/ipc/json-internal.cc
Outdated
| *type = date64(); | ||
| } else if (type_name == "time") { | ||
| return GetTimeLike<TimeType>(json_type, type); | ||
| // TODO: 32-bit vs 64-bit time |
Member
There was a problem hiding this comment.
Still relevant? It looks like this is implemented.
Member
Author
There was a problem hiding this comment.
will remove, thanks. Planning to do some cleaning on this module while completing the JSON read/write support
Member
Author
|
I am going to fix glib compilation, remove the TODO, and then merge |
Change-Id: I12601bd38869ae1a300dad394d48d71ed7df6707
Change-Id: I4701f866f1ab23ad61d99a2411937dafc5ad2b75
Member
Author
|
This build passes except for parquet-cpp build failure. I filed PARQUET-923 |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
This is first part of bloom filter patch set, which include a bloom filter utility and also some unit tests. Note that this patch also includes murmur3Hash original code from Austin Appleby. The code isn't formatted as parquet-cpp format. Author: Chen, Junjie <[email protected]> Closes apache#432 from cjjnjust/master and squashes the following commits: d4d3018 [Chen, Junjie] PARQUET-1332: update constructor b0f3f80 [Chen, Junjie] PARQUET-1332: update code for some coding style fe97b44 [Chen, Junjie] PARQUET-1332: refine the complex classes fd3ba23 [Chen, Junjie] PARQUET-1332: fix build error for clang Xcode 019322a [Chen, Junjie] PARQUET-1332: refine bloom filter algorithm ec6a6e9 [Chen, Junjie] PARQUET-1332: fix build failure for windows platform 0c1e95f [Chen, Junjie] PARQUET-1332: update according to latest comments 1a105fc [Chen, Junjie] PARQUET-1332: update code according to Jim's comments 731191c [Chen, Junjie] PARQUET-1332: rebase to latest to solve CI error and update comments 0bc8595 [Chen, Junjie] PARQUET-1332: use abstract class for hash class 1374665 [Chen, Junjie] PARQUET-1332: update according to code review 858b2ce [Chen, Junjie] PARQUET-1332: remove unnecessary const_cast 23d7ccf [Chen, Junjie] PARQUET-1332: add missing file f2ff8ad [Chen, Junjie] PARQUET-1332: Add bloom filter utility class Change-Id: Ia0f684f994dd89a7a8093ed80cdabc0ddd76cae3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also has a little visitor refactoring