GH-43039: Unable to create a list of Maps with Decimal key or value #43072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: DO NOT REVIEW
Rationale for this change
The
MapVectorcreation withDecimalkeys or values contains an issue as reported apache/arrow-java#69. MapVector writers are missing support for defining a decimal based key or value.What changes are included in this PR?
Test cases for creating a
MapVectorwith decimal keys and values. Adding a new methods forListWriterinterface to accommodate decimal inclusion.Are these changes tested?
Tested via existing test cases and new test cases.
Are there any user-facing changes?
Yes. New API has been added to support decimal based keys and values in
MapVectorcreation.