Skip to content

GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting #41610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 3 commits into from
Closed

GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting #41610

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6b2614
Add tests
viirya May 9, 2024
3146a33
Fix
viirya May 9, 2024
2d105ac
Fix typo
viirya May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions java/c/src/test/java/org/apache/arrow/c/RoundtripTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,42 @@ public void testVarCharVector() {
}
}

@Test
public void testEmptyVarCharVector() {
try (final VarCharVector vector = new VarCharVector("v", allocator)) {
vector.allocateNewSafe();
vector.setValueCount(0);
assertTrue(roundtrip(vector, VarCharVector.class));
}
}

@Test
public void testEmptyLargeVarCharVector() {
try (final LargeVarCharVector vector = new LargeVarCharVector("v", allocator)) {
vector.allocateNewSafe();
vector.setValueCount(0);
assertTrue(roundtrip(vector, LargeVarCharVector.class));
}
}

@Test
public void testEmptyVarBinaryVector() {
try (final VarBinaryVector vector = new VarBinaryVector("v", allocator)) {
vector.allocateNewSafe();
vector.setValueCount(0);
assertTrue(roundtrip(vector, VarBinaryVector.class));
}
}

@Test
public void testEmptyLargeVarBinaryVector() {
try (final LargeVarBinaryVector vector = new LargeVarBinaryVector("v", allocator)) {
vector.allocateNewSafe();
vector.setValueCount(0);
assertTrue(roundtrip(vector, LargeVarBinaryVector.class));
}
}

@Test
public void testLargeVarBinaryVector() {
try (final LargeVarBinaryVector vector = new LargeVarBinaryVector("", allocator)) {
Expand Down