-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-5108: [Go] implement reading primitive arrays from Arrow file #4114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@stuartcarnie @alexandreyc PTAL. it's a lot of code, but most of it is coming from the automatically generated code from flatbuffers.
|
|
Is there a way to generate the Flatbuffers bindings at build time or do the files have to be checked in? |
Codecov Report
@@ Coverage Diff @@
## master #4114 +/- ##
==========================================
- Coverage 88.44% 87.87% -0.57%
==========================================
Files 752 758 +6
Lines 91515 92163 +648
Branches 1251 1251
==========================================
+ Hits 80937 80990 +53
- Misses 10457 11052 +595
Partials 121 121
Continue to review full report at Codecov.
|
|
@wesm: this (unfortunately?) isn't the way Gophers like to do it. |
19f8637 to
0f98156
Compare
|
the flurry of activity is now done. PTAL |
go/arrow/ipc/message.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why you switched from pointer to value receiver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was mainly to convey that method wouldn't modify the receiver.
I can switch to pointer receiver.
go/arrow/ipc/message.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe check for msg.meta and msg.body to be not nil before releasing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put the check+panic in the NewMessage instead.
stuartcarnie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see this work 🎉
|
PTAL. |
nickpoorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
This CL adds the generation of flatbuffers-based files for the IPC backend. This CL adds the basic functionality to read an Arrow file.
This CL adds the generation of flatbuffers-based files for the IPC backend.
This CL adds the basic functionality to read an Arrow file.