Skip to content

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Mar 12, 2024

Rationale for this change

The latest version of pytest (8.0.0) is breaking our CI:

  • S3 fixture from out test suite fails
  • doctest-cython check fails

What changes are included in this PR?

  • added allow_bucket_creation=True to the s3_example_fs fixture
  • removed the pin on pytest, except for the doc builds

Are these changes tested?

Yes.

Are there any user-facing changes?

No

Closes:

@github-actions
Copy link

⚠️ GitHub issue #39958 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member

kou commented Mar 12, 2024

@github-actions crossbow submit -g python

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if CI is green

BTW, could you use our PR template instead of just listing related issue links?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 12, 2024
@github-actions
Copy link

Revision: 701807a

Submitted crossbow builds: ursacomputing/crossbow @ actions-2dab689a54

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-11-python-3-amd64 Azure
test-debian-11-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 13, 2024

BTW, could you use our PR template instead of just listing related issue links?

Will do, thank you for reminding me!

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 13, 2024

@jorisvandenbossche do you mind giving a quick look at this changes?

@jorisvandenbossche
Copy link
Member

I would personally prefer keeping doctest-cython running on our CI. Is it urgent to remove the pytest pin? Or we could also leave the pin just for the docs build where the doctests are ran?

@jorisvandenbossche
Copy link
Member

added allow_bucket_creation=True to the s3_example_fs fixture

Do we have any understanding about why pytest 8 needs this change?

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 13, 2024

I would personally prefer keeping doctest-cython running on our CI. Is it urgent to remove the pytest pin? Or we could also leave the pin just for the docs build where the doctests are ran?

We can also wait with merging this PR till lgpage/pytest-cython#58 is merged. I am OK with any of the proposed options.

added allow_bucket_creation=True to the s3_example_fs fixture

Do we have any understanding about why pytest 8 needs this change?

No 😊 Will research.

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 18, 2024

I have kept the doctest-cython command on our CI (conda-python-docs) and pinned pytest to lower than 8 in this case.

As for the allow_bucket_creation=True in the s3_example_fs fixture, we have agreed there is no point in spending too much time on researching why it is needed. Looking at the PR that added this argument in other cases where S3FileSystem is created from a URI (#13206) it makes sense to also add it to the s3_example_fs fixture.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Mar 19, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 19, 2024
@jorisvandenbossche
Copy link
Member

@github-actions crossbow submit -g python

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Mar 19, 2024
@github-actions
Copy link

Revision: d5b4d40

Submitted crossbow builds: ursacomputing/crossbow @ actions-3ecfe9f5ae

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-11-python-3-amd64 Azure
test-debian-11-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Mar 19, 2024
@jorisvandenbossche jorisvandenbossche merged commit 6d5cfb2 into apache:main Mar 19, 2024
@jorisvandenbossche jorisvandenbossche removed the awaiting merge Awaiting merge label Mar 19, 2024
@jorisvandenbossche
Copy link
Member

Thanks!

@AlenkaF AlenkaF deleted the gh-39957-unpin-pytest branch March 19, 2024 15:24
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python][CI] Remove upper pin on pytest [Python][CI] S3 fixtures fail with Pytest 8.0.0

3 participants