-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-39958: [Python][CI] Remove upper pin on pytest #40487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39958: [Python][CI] Remove upper pin on pytest #40487
Conversation
|
|
|
@github-actions crossbow submit -g python |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 if CI is green
BTW, could you use our PR template instead of just listing related issue links?
|
Revision: 701807a Submitted crossbow builds: ursacomputing/crossbow @ actions-2dab689a54 |
Will do, thank you for reminding me! |
|
@jorisvandenbossche do you mind giving a quick look at this changes? |
|
I would personally prefer keeping doctest-cython running on our CI. Is it urgent to remove the pytest pin? Or we could also leave the pin just for the docs build where the doctests are ran? |
Do we have any understanding about why pytest 8 needs this change? |
We can also wait with merging this PR till lgpage/pytest-cython#58 is merged. I am OK with any of the proposed options.
No 😊 Will research. |
|
I have kept the As for the |
|
@github-actions crossbow submit -g python |
|
Revision: d5b4d40 Submitted crossbow builds: ursacomputing/crossbow @ actions-3ecfe9f5ae |
|
Thanks! |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 6d5cfb2. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Rationale for this change
The latest version of pytest (
8.0.0) is breaking our CI:doctest-cythoncheck failsWhat changes are included in this PR?
allow_bucket_creation=Trueto thes3_example_fsfixtureAre these changes tested?
Yes.
Are there any user-facing changes?
No
Closes: