-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: [CI] Update allowed_roles for crossbow submission #39610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b59082a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
@assignUser Can we re-allow crossbow submission to contributors who has at least one commit to apache/arrow? For example, allowing crossbow submission to @Tom-Newton is valuable.
Does this mean that apache/arrow uses the "Require approval for all outside collaborators" setting? It seems that apache/arrow uses the "Require approval for first-time contributors" setting. Because workflows for #39622 were allowed without our explicit approval. |
|
I would appreciate permissions for crossbow submissions but its probably not necessary. I've finally got my local windows build working sufficiently that I should be able to get #39622 passing everything in the next attempt. Initially I was struggling to configure docker windows containers to use a local drive with sufficient space. |
|
OK! |
### Rationale for this change Improved security, this aligns the permissions with the current default repo setting of required approval for all contributors. ### What changes are included in this PR? Only committers (members,owner and collaborator of ASF org) can submit a crossbow job. ### Are these changes tested? Not possible. Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Improved security, this aligns the permissions with the current default repo setting of required approval for all contributors.
What changes are included in this PR?
Only committers (members,owner and collaborator of ASF org) can submit a crossbow job.
Are these changes tested?
Not possible.