Skip to content

Conversation

@assignUser
Copy link
Member

@assignUser assignUser commented Jan 15, 2024

Rationale for this change

Improved security, this aligns the permissions with the current default repo setting of required approval for all contributors.

What changes are included in this PR?

Only committers (members,owner and collaborator of ASF org) can submit a crossbow job.

Are these changes tested?

Not possible.

@assignUser assignUser requested review from kou and raulcd as code owners January 15, 2024 15:31
@assignUser assignUser self-assigned this Jan 15, 2024
@github-actions github-actions bot added the awaiting review Awaiting review label Jan 15, 2024
@assignUser assignUser added this to the 16.0.0 milestone Jan 15, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit b59082a into apache:main Jan 16, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 16, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b59082a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@kou
Copy link
Member

kou commented Jan 22, 2024

@assignUser Can we re-allow crossbow submission to contributors who has at least one commit to apache/arrow? For example, allowing crossbow submission to @Tom-Newton is valuable.
See also: #39622

Improved security, this aligns the permissions with the current default repo setting of required approval for all contributors.

Does this mean that apache/arrow uses the "Require approval for all outside collaborators" setting?
See also: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories

It seems that apache/arrow uses the "Require approval for first-time contributors" setting. Because workflows for #39622 were allowed without our explicit approval.

@Tom-Newton
Copy link
Contributor

I would appreciate permissions for crossbow submissions but its probably not necessary. I've finally got my local windows build working sufficiently that I should be able to get #39622 passing everything in the next attempt.

Initially I was struggling to configure docker windows containers to use a local drive with sufficient space.

@kou
Copy link
Member

kou commented Jan 22, 2024

OK!

@assignUser assignUser deleted the crossbow-member-only branch January 22, 2024 22:05
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

Improved security, this aligns the permissions with the current default repo setting of required approval for all contributors.

### What changes are included in this PR?

Only committers (members,owner and collaborator of ASF org) can submit a crossbow job.

### Are these changes tested?
Not possible.

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants