GH-39134: [Java] Create module info compiler plugin #39135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jduo
force-pushed
the
create-module-info-compiler
branch
from
a26e026 to
1e1c045
Compare
lidavidm
approved these changes
Dec 8, 2023
Member
There was a problem hiding this comment.
Why do we want to avoid the defaults/are these inconsistent with the global config?
Member
Author
There was a problem hiding this comment.
This was generated by the maven plugin archetype I used.
github-actions
bot
added
awaiting merge
jduo
force-pushed
the
create-module-info-compiler
branch
from
1e1c045 to
0aa8605
Compare
Note that some configuration from the arrow root POM is copied to the maven plugins module because it cannot be inherited without creating a cyclic depdendency.
Reports a used dependency as unused only on Windows 2022 CI runs
It is not correctly getting skipped.
This won't build with the JDK 8 target
Newer versions of the checkstyle plugin do support module-info.java files but require rewriting the checkstyle rules file.
Add a test goal to the module-info-compiler plugin. Rename goals to be consistent with maven-compiler-plugin
jduo
force-pushed
the
create-module-info-compiler
branch
from
0aa8605 to
dea90f9
Compare
Member
|
@github-actions crossbow submit java |
|
Revision: dea90f9 Submitted crossbow builds: ursacomputing/crossbow @ actions-0fe7a83d3b
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d0e74d7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
kou
changed the title
Member
Member
|
@jduo It seems that this broke our documentation CI job. Could you check it? https://github.com/apache/arrow/actions/runs/7182308293/job/19558525786#step:7:13088 |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Create and integrate a maven plugin for compiling module-info.java files without using maven-compiler-plugin and release 9+. This is necessary for supporting Java 8 unsafe code, which has different than unsafe code in JDK 9. ### What changes are included in this PR? - Add the module-info-compiler-maven-plugin and utilize it in the codebase. - Exclude module-info.java files from maven-compiler-plugin. ### Are these changes tested? Yes, they generate valid module-info.class files in JARs and test JARs. ### Are there any user-facing changes? No * Closes: apache#39134 Authored-by: James Duong <[email protected]> Signed-off-by: David Li <[email protected]>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
### Rationale for this change Create and integrate a maven plugin for compiling module-info.java files without using maven-compiler-plugin and release 9+. This is necessary for supporting Java 8 unsafe code, which has different than unsafe code in JDK 9. ### What changes are included in this PR? - Add the module-info-compiler-maven-plugin and utilize it in the codebase. - Exclude module-info.java files from maven-compiler-plugin. ### Are these changes tested? Yes, they generate valid module-info.class files in JARs and test JARs. ### Are there any user-facing changes? No * Closes: apache#39134 Authored-by: James Duong <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Create and integrate a maven plugin for compiling module-info.java files without using maven-compiler-plugin
and release 9+. This is necessary for supporting Java 8 unsafe code, which has different than unsafe code
in JDK 9.
What changes are included in this PR?
Are these changes tested?
Yes, they generate valid module-info.class files in JARs and test JARs.
Are there any user-facing changes?
No