-
Notifications
You must be signed in to change notification settings - Fork 3.8k
GH-37392: [JS] Remove lerna #37393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37392: [JS] Remove lerna #37393
Conversation
@@ -66,10 +66,6 @@ This argument configuration also applies to `clean` and `test` scripts. | |||
To run tests on the bundles, you need to build them first. | |||
To run tests directly on the sources without bundling, use the `src` target (e.g. `yarn test -t src`). | |||
|
|||
* `yarn deploy` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already not working so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c9bfca5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
We only use learna for making releases and can easily replace it with a bash script. * Closes: apache#37392 Authored-by: Dominik Moritz <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
## What's Changed Removed `lerna` from `package`json` because we removed `lerna` in apache/arrow#37393. Closes #143.
We only use learna for making releases and can easily replace it with a bash script.