GH-36831: [C++] DictionaryArray support for MinMax Function

[R-JunmingChen]

Rationale for this change

As #36831 requires, a MinMax kernel for DictionaryArray is supported.

What changes are included in this PR?

Add a DictionaryType kernel for MinMax

Are these changes tested?

Yes, A test is added in aggregate_test.cc

Are there any user-facing changes?

No.

• Closes: [C++] Dictionary support for ordering-based compute functions. #36831
• GitHub Issue: [C++] Dictionary support for ordering-based compute functions. #36831

[github-actions]

⚠️ GitHub issue #36831 has been automatically assigned in GitHub to PR creator.

[R-JunmingChen]

Hi, reviewers, I need a guidance.

The resolved output type for DictionaryType MinMax Kernel is DictionaryType now. But I think the MinMax output type should be the DataType of the values of the DictionaryType. So, in my implementation, I use the DataType of the values of the DictionaryType as output type, which raise an error like the following img currently.

Can we have a correct resolved output type? and where are the codes should be changed? It should be mentioned that we can only obtain the output type in the runtime instead of compile time.

[js8544]

The AddMinMaxKernel function declares the signature with output MinMaxType as output, you should modify this function if you want it to output its value type instead of the dictionary itself.

Be aware that min and max also reuse the min_max kernels, so you should take a look at AddMinOrMaxAggKernel too.

[R-JunmingChen]

Hi, @pitrou, @js8544. please review this PR when you have time.

[R-JunmingChen]

hi, @bkietz, could you please review this PR when you have time?

[bkietz]

LGTM, but please rebase and correct the CI failure

One item for potential follow up:

[bkietz]

@R-JunmingChen sorry for letting this slip off my radar! Could you rebase please?

[R-JunmingChen]

Hi, @bkietz, I have merged the latest main branch. The only one CI error seems not related

[R-JunmingChen]

ping @bkietz

[R-JunmingChen]

ping @bkietz again

[mapleFU]

@pitrou Would you mind check this?

[github-actions]

Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.