Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Aug 3, 2023

Rationale for this change

Docs were out of data with code after previous changes to returned object type

What changes are included in this PR?

Update docs to reflect correct return type

Are these changes tested?

No

Are there any user-facing changes?

No

@thisisnic thisisnic marked this pull request as ready for review August 3, 2023 22:48
@thisisnic thisisnic requested a review from paleolimbot as a code owner August 3, 2023 22:48
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thisisnic thisisnic merged commit 2972e49 into apache:main Aug 9, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2972e49.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

raulcd pushed a commit that referenced this pull request Aug 16, 2023
…37020)

### Rationale for this change

Docs were out of data with code after previous changes to returned object type

### What changes are included in this PR?

Update docs to reflect correct return type

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: #37019

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…ting (apache#37020)

### Rationale for this change

Docs were out of data with code after previous changes to returned object type

### What changes are included in this PR?

Update docs to reflect correct return type

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37019

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R] Documentation for read_parquet() et al needs updating

2 participants