-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-36634: [Dev] Ensure merge script goes over all pages when requesting info from GitHub #36637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…questing info from GitHub
|
There are currently no tests on the merge_pr script around neither GH issues or any interaction with GH. We should add them but this is tracked on this PR: #14802 |
|
Just for the record, other libraries like pygithub use the link header for the pagination and do a similar parsing: https://github.com/PyGithub/PyGithub/blob/de80ff4b914b9ffd47347d60b14cbf270e07f346/github/PaginatedList.py#L241 |
assignUser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch! Is this something we need to add to archery somewhere too? Or not as that is using an api wrapper that handles it?
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Co-authored-by: Sutou Kouhei <[email protected]>
The pygithub and github3.py libraries used on archery handle pagination. I am not sure if there's any place where we should explicitly call to get next pages, etcetera but I don't think so as from what I've seen they just return iterators and handle that for us. Would be good though to try and refactor archery to use a single library so we are sure around those: #33241 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit a4384d9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We currently were missing maintenance branches due to pagination on GH API.
What changes are included in this PR?
Check whether the API is returning a paginated view and extend the list returned.
Are these changes tested?
I have tested locally:
Are there any user-facing changes?
No