-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-34956: [Docs][Python] Add to docs the usage of the FixedShapeTensorType #34957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two nits.
rok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I am currently adding some more text. Will probably have extra content ready tomorrow morning! |
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some small comments.
I understand that we initially added this to extending_types.rst (when it was an example of implementing it). But now this is actually part of pyarrow, I am wondering if we would want to move it to a different location in our docs.
Currently, other data types are mentioned at https://arrow.apache.org/docs/dev/python/data.html, but that's already a long page about a lot of things, so also wouldn't just add it there. Maybe for now we can keep it here, and can think about reorganizing it later.
…HW to NHWC format
Co-authored-by: Rok Mihevc <[email protected]>
4ca6485 to
b3e3a57
Compare
I will open an issue for this as I agree it should be reorganised (and I just remembered we have talked about this before, sorry). Otherwise I have included the changes with the last two commits. |
|
Thank you Joris and Rok for reviews! |
|
Benchmark runs are scheduled for baseline = 07642fd and contender = b8427d3. b8427d3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…eTensorType (apache#34957) ### Rationale for this change This PR adds examples of the use of `FixedShapeTensorType`to the PyArrow user guide. Should be reviewed and merged after apache#34883 is done. * Closes: apache#34956 Lead-authored-by: Alenka Frim <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Co-authored-by: Rok Mihevc <[email protected]> Signed-off-by: Alenka Frim <[email protected]>
…eTensorType (apache#34957) ### Rationale for this change This PR adds examples of the use of `FixedShapeTensorType`to the PyArrow user guide. Should be reviewed and merged after apache#34883 is done. * Closes: apache#34956 Lead-authored-by: Alenka Frim <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Co-authored-by: Rok Mihevc <[email protected]> Signed-off-by: Alenka Frim <[email protected]>

Rationale for this change
This PR adds examples of the use of
FixedShapeTensorTypeto the PyArrow user guide. Should be reviewed and merged after #34883 is done.