Skip to content

Conversation

@igor-suhorukov
Copy link
Contributor

@igor-suhorukov igor-suhorukov commented Mar 1, 2023

Update status documentation: CSV read in Java from #14182

Update status documentation: CSV read in Java from #14182
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@jorisvandenbossche jorisvandenbossche changed the title Update status documentation as per ARROW-17786 MINOR: [Docs][Java] Update status documentation for Java's CSV read support (as per ARROW-17786) Mar 1, 2023
@raulcd raulcd requested a review from lidavidm March 1, 2023 11:16
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one comment.

| Avro | | R | | | | | |
+-----------------------------+---------+---------+-------+------------+-------+-------+-------+
| CSV | R/W | | R/W | | | R/W | R/W |
| CSV | R/W | R | R/W | | | R/W | R/W |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the caveat that it's through JNI (like for ORC below).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lidavidm Thank you for review! Done

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 1, 2023
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lidavidm lidavidm merged commit 5a7d89c into apache:main Mar 2, 2023
@ursabot
Copy link

ursabot commented Mar 2, 2023

Benchmark runs are scheduled for baseline = 2ebb3f7 and contender = 5a7d89c. 5a7d89c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.43% ⬆️0.0%] test-mac-arm
[Finished ⬇️1.53% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5a7d89cf ec2-t3-xlarge-us-east-2
[Failed] 5a7d89cf test-mac-arm
[Finished] 5a7d89cf ursa-i9-9960x
[Finished] 5a7d89cf ursa-thinkcentre-m75q
[Finished] 2ebb3f70 ec2-t3-xlarge-us-east-2
[Failed] 2ebb3f70 test-mac-arm
[Finished] 2ebb3f70 ursa-i9-9960x
[Finished] 2ebb3f70 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Mar 2, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants