You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expectation is that any custom properties set on the JDBC connection are sent across on every request. This PR ensures the handshake request gets those headers as well.
What changes are included in this PR?
Ensure custom headers are sent during auth handshake
Looks like `getAuthenticate` makes a request to the server before it
adds the `CredentialCallOption` to the client options. In order to
send the existing `CallOptions` we need to pass them in to `getAuthenticate`
lidavidm
changed the title
GH-33874 [Java] Ensure custom headers are included during JDBC auth handshake
GH-33874: [Java] Ensure custom headers are included during JDBC auth handshake
Jan 31, 2023
… auth handshake (apache#33946)
### Rationale for this change
The expectation is that any custom properties set on the JDBC connection are sent across on every request. This PR ensures the handshake request gets those headers as well.
### What changes are included in this PR?
Ensure custom headers are sent during auth handshake
### Are these changes tested?
No, not sure where the best place to test this.
### Are there any user-facing changes?
No, other than seeing expected behavior.
* Closes: apache#33874
Authored-by: Diego Fernandez <[email protected]>
Signed-off-by: David Li <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lidavidm
changed the title
Rationale for this change
The expectation is that any custom properties set on the JDBC connection are sent across on every request. This PR ensures the handshake request gets those headers as well.
What changes are included in this PR?
Ensure custom headers are sent during auth handshake
Are these changes tested?
No, not sure where the best place to test this.
Are there any user-facing changes?
No, other than seeing expected behavior.