-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-3803: [C++/Python] Merge C++ builds and tests, run Python tests in separate CI entries #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We may be reaching the end of the road with Xcode 6.4. Travis is pulling support for the image in January 2019 according to messages in the build logs. Gandiva does not run properly (due to a strptime bug?) on 6.4 so we might move everything to 8.3. We should see what conda-forge is planning exactly, since if they are remaining on 6.4 then we may not be able to have Gandiva in the Python wheels |
|
@wesm current change lgtm i.e CI has gandiva with Xcode 8.3 but not Xcode 6.4. If gandiva with Xcode 6.4 becomes important/required for any reason, we can spend some time on workarounds to make it work. |
|
I opened https://issues.apache.org/jira/browse/ARROW-4068 about Xcode 6.4. If you know what problems there are, could you post them there? I'm working on getting a reliable macOS box where I can do development and testing |
|
I ran into https://issues.apache.org/jira/browse/ARROW-4070 here when trying to use ARROW_BOOST_VENDORED with ninja |
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LD_LIBRARY_PATH is less invasive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LD_LIBRARY_PATH is already set...
https://github.com/apache/arrow/blob/master/ci/travis_env_common.sh#L63
|
I think this is almost there. I'm just waiting on the Gandiva valgrind fixes to go in. If folks could take pity on me and try to not touch the CI scripts any more until this is merged that would be really great |
Codecov Report
@@ Coverage Diff @@
## master #3208 +/- ##
==========================================
+ Coverage 67.62% 88.2% +20.58%
==========================================
Files 58 550 +492
Lines 4012 73840 +69828
==========================================
+ Hits 2713 65132 +62419
- Misses 1192 8601 +7409
Partials 107 107
Continue to review full report at Codecov.
|
will do. thanks. |
* Use gcc 4.8 * Pin boost-cpp 1.68.0 due to crashes caused by 1.69.0
Change-Id: Ibb33a4fcabfc6da86089c4cef1e6b7f0872f7262
|
Rebased. Will merge once the build runs |
|
Running all the C++ unit tests under valgrind is taking about 23 minutes This is OK for now, but may not be scalable. |
|
The Appveyor builds passed (Rust is still running -- I opened https://issues.apache.org/jira/browse/ARROW-4080) |
… in separate CI entries I found unfortunately that the conda-forge boost-cpp package is not fully compatible with Xcode 8.3, see https://issues.apache.org/jira/browse/ARROW-4056 We might have to build a vendored Boost in this CI entry to work around the problem (this is what the Ray project did when they also hit this issue) Author: Wes McKinney <[email protected]> Closes apache#3208 from wesm/ARROW-3803 and squashes the following commits: 7c47776 <Wes McKinney> Remove now unneeded travis_script_gandiva_cpp.sh 9c8d6aa <Wes McKinney> * Combine C++ CI jobs, split Python CI jobs into separate build entries * Use gcc 4.8 * Pin boost-cpp 1.68.0 due to crashes caused by 1.69.0

I found unfortunately that the conda-forge boost-cpp package is not fully compatible with Xcode 8.3, see https://issues.apache.org/jira/browse/ARROW-4056
We might have to build a vendored Boost in this CI entry to work around the problem (this is what the Ray project did when they also hit this issue)