Skip to content

ARROW-75: Fix handling of empty strings #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danrobinson wants to merge 4 commits into from
Closed

ARROW-75: Fix handling of empty strings #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ef3b75
ARROW-75: Fix handling of empty strings
danrobinson Mar 22, 2016
722df19
ARROW-75: Fixed braces
danrobinson Mar 22, 2016
9604a21
ARROW-75: Changed tests
danrobinson Mar 22, 2016
cb8e527
ARROW-75: remove whitespace
danrobinson Mar 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/src/arrow/types/primitive.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,9 @@ class PrimitiveBuilder : public ArrayBuilder {
int32_t new_capacity = util::next_power2(length_ + length);
RETURN_NOT_OK(Resize(new_capacity));
}
memcpy(raw_buffer() + length_, values, length * elsize_);
if (length > 0) {
memcpy(raw_buffer() + length_, values, length * elsize_);
}

if (null_bytes != nullptr) {
AppendNulls(null_bytes, length);
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/types/string-test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class TestStringBuilder : public TestBuilder {
};

TEST_F(TestStringBuilder, TestScalarAppend) {
std::vector<std::string> strings = {"a", "bb", "", "", "ccc"};
std::vector<std::string> strings = {"", "bb", "a", "", "ccc"};
std::vector<uint8_t> is_null = {0, 0, 0, 1, 0};

int N = strings.size();
Expand Down
6 changes: 3 additions & 3 deletions python/pyarrow/tests/test_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ def test_list_format(self):
assert result == expected

def test_string_format(self):
arr = pyarrow.from_pylist(['foo', None, 'bar'])
arr = pyarrow.from_pylist(['', None, 'foo'])
result = fmt.array_format(arr)
expected = """\
[
'foo',
'',
NA,
'bar'
'foo'
]"""
assert result == expected

Expand Down