Skip to content

ARROW-402: avoid empty buffers #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julienledem wants to merge 3 commits into from
Closed

ARROW-402: avoid empty buffers #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db4337
ARROW-402: avoid empty buffers
julienledem Dec 9, 2016
7968813
actual fix
julienledem Dec 9, 2016
3269ca8
with tests
julienledem Dec 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion java/vector/src/main/java/org/apache/arrow/vector/BitVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ public BitVector(String name, BufferAllocator allocator) {
public void load(ArrowFieldNode fieldNode, ArrowBuf data) {
// When the vector is all nulls or all defined, the content of the buffer can be omitted
if (data.readableBytes() == 0 && fieldNode.getLength() != 0) {
data.release();
int count = fieldNode.getLength();
allocateNew(count);
int n = getSizeFromCount(count);
Expand Down
4 changes: 3 additions & 1 deletion java/vector/src/test/java/org/apache/arrow/vector/TestVectorUnloadLoad.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ public void testLoadEmptyValidityBuffer() throws IOException {
new Field("intNull", true, new ArrowType.Int(32, true), Collections.<Field>emptyList())
));
int count = 10;
ArrowBuf validity = allocator.getEmpty();
// using Allocator.getEmpty() turns off ref counting
ArrowBuf validity = allocator.buffer(10).slice(0, 0);
ArrowBuf values = allocator.buffer(count * 4); // integers
for (int i = 0; i < count; i++) {
values.setInt(i * 4, i);
Expand Down Expand Up @@ -153,6 +154,7 @@ public void testLoadEmptyValidityBuffer() throws IOException {
assertFalse(intDefinedVector.getAccessor().isNull(count + 10));
assertEquals(1234, intDefinedVector.getAccessor().get(count + 10));
} finally {
validity.release();
values.release();
}
}
Expand Down