ARROW-1722: [C++] Add linting script to find C++/CLI incompatibilities #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze they are being installed
Member
Author
|
I opened https://issues.apache.org/jira/browse/ARROW-2810 -- I was surprised to find Plasma installs its generated Flatbuffers files |
Codecov Report
@@ Coverage Diff @@
## master #2225 +/- ##
==========================================
+ Coverage 84.1% 84.14% +0.03%
==========================================
Files 288 288
Lines 43865 43933 +68
==========================================
+ Hits 36892 36966 +74
+ Misses 6942 6940 -2
+ Partials 31 27 -4
Continue to review full report at Codecov.
|
xhochy
reviewed
Jul 8, 2018
cpp/build-support/lint_cpp_cli.py
Outdated
| exclude = False | ||
| for exclusion in EXCLUSIONS: | ||
| if exclusion in full_path: | ||
| # print('Skipping excluded header: {0}'.format(filename)) |
Member
There was a problem hiding this comment.
Remove or replace with logger.debug
xhochy
approved these changes
Jul 8, 2018
kou
approved these changes
Jul 9, 2018
| arguments = parser.parse_args() | ||
|
|
||
|
|
||
| _STRIP_COMMENT_REGEX = re.compile('(.+)?(?=//)') |
Member
There was a problem hiding this comment.
'(.+?)?(?=//)' will be better for a // b // c case but it's too trivial. We will never write such code :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes some issues that the script found