Skip to content

Conversation

@assignUser
Copy link
Member

@assignUser assignUser commented Dec 29, 2022

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #15114 has been automatically assigned in GitHub to PR creator.

@assignUser assignUser changed the title GH-15114: [R][CI] Homebrew can't install 3.11 on GHA runners GH-15114: [R][C++][CI] Homebrew can't install 3.11 on GHA runners Dec 29, 2022
@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-cpp homebrew-r-*

@github-actions
Copy link

Revision: 683b7c002761dfebc7eda4b3c5b261896283c47f

Submitted crossbow builds: ursacomputing/crossbow @ actions-f42135e82c

Task Status
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
homebrew-r-brew Github Actions

@assignUser assignUser requested a review from jonkeane December 29, 2022 20:02
@assignUser
Copy link
Member Author

It does not look like it but the fix worked xD
the macos 11 jobs are still failing because of the head() issue (#14582 ) and the 10.13 jobs are now failing because of the missing pyarrow wheels (#15115)

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One substantive comment.

On the crossbow builds:

It looks like the homebrew-r-autobrew jobs are all still failing: the 10.13 ones should be resolved by #15117 yeah? (and then the 11 ones by the head issue).

But what's up with the homebrew-r-brew failure? Is that expected? It looks like it's the same failure we were seeing for homebrew-cpp, no?

Comment on lines 32 to 34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, this is a pretty expansive glob that could impact a number of different files — any way that we could make it be a bit more specific to the issue we're seeing? Either (or both of): looking for 3.11 specifically, only running this on (specific) github runners? Or maybe even better: brew link --overwrite [email protected] which is suggested in the message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the idea was to not have to add multiple things manually after retrying a bunch but being eplicit is probably for the best (e.g. rm '/usr/local/bin/2to3-3.11').

This is only done on the affected runners (non-10.13), using overwrite would require us to change it in the brew internals which would affect everyone not just these (wrongly configured) CI runners.

I'll switch this to the explicit removal, that will probably also fix the brew job for which the glob apparently failed...

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still -0.1 on manually removing these files versus trying to use the brew-specific recommendation here (mostly because it looks like this might become a non-trivial maintenance burden for us in the future), but happy to merge this now so we can stem the failures as much as possible.

@assignUser
Copy link
Member Author

After some investigating it looks like this might be a brew issue related to brew update, as this only happens after that. (reprex) I'll open an issue over in homebrew.

We can try installing python manually with overwrite instead of deleting the things. I will try this in a moment

@assignUser
Copy link
Member Author

assignUser commented Jan 2, 2023

@github-actions crossbow submit homebrew-cpp homebrew-r-*

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Unable to match any tasks for `hombrew-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/3823586622

@assignUser assignUser force-pushed the fix-homebrew-python branch 2 times, most recently from ae26c1c to 817bcf1 Compare January 2, 2023 15:33
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Revision: ae26c1cd47d901a38a0633e1cac8a15fe63b5d38

Submitted crossbow builds: ursacomputing/crossbow @ actions-0340e835bf

Task Status
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
homebrew-r-brew Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-cpp homebrew-r-*

re-trigger after rebase

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Revision: 817bcf1e76b5080badf0c4759d77aeda3fe85321

Submitted crossbow builds: ursacomputing/crossbow @ actions-85e08faefe

Task Status
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
homebrew-r-brew Github Actions

@paleolimbot
Copy link
Member

I just merged the head() PR fix (#14582) if you want to try rebasing on that!

@assignUser
Copy link
Member Author

I just merged the head() PR fix (#14582) if you want to try rebasing on that!

oh yeah :D

@assignUser assignUser force-pushed the fix-homebrew-python branch from 817bcf1 to 368765c Compare January 2, 2023 20:13
@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-cpp homebrew-r-brew

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Revision: 368765c

Submitted crossbow builds: ursacomputing/crossbow @ actions-5b6f419ad0

Task Status
homebrew-cpp Github Actions
homebrew-r-brew Github Actions

@assignUser assignUser requested a review from jonkeane January 2, 2023 21:52
@pitrou pitrou changed the title GH-15114: [R][C++][CI] Homebrew can't install 3.11 on GHA runners GH-15114: [R][C++][CI] Homebrew can't install Python 3.11 on GHA runners Jan 3, 2023
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 I thought this approach would be simpler — but I didn't think it would be this much simpler.

One small comment asking for a comment, but happy to merge this otherwise.

@assignUser assignUser requested a review from jonkeane January 3, 2023 18:01
@jonkeane jonkeane merged commit 4dd5ced into apache:master Jan 3, 2023
@ursabot
Copy link

ursabot commented Jan 4, 2023

Benchmark runs are scheduled for baseline = 44bd06d and contender = 4dd5ced. 4dd5ced is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Finished ⬇️4.34% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4dd5cedb ec2-t3-xlarge-us-east-2
[Failed] 4dd5cedb test-mac-arm
[Finished] 4dd5cedb ursa-i9-9960x
[Failed] 4dd5cedb ursa-thinkcentre-m75q
[Finished] 44bd06d8 ec2-t3-xlarge-us-east-2
[Failed] 44bd06d8 test-mac-arm
[Finished] 44bd06d8 ursa-i9-9960x
[Failed] 44bd06d8 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 4, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
…A runners (apache#15116)

* Closes: apache#15114

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R][C++][CI] Homebrew can't install 3.11 on GHA runners

4 participants