Skip to content

Conversation

@paleolimbot
Copy link
Member

This PR enables the following to work:

library(arrow, warn.conflicts = FALSE)
#> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.

register_scalar_function(
  "times_32",
  function(context, x) x * 32.0,
  int32(),
  float64(),
  auto_convert = TRUE
)

record_batch(a = 1:1000) |> 
  dplyr::mutate(b = times_32(a)) |> 
  as_record_batch_reader() |> 
  head(11) |> 
  as_arrow_table()
#> Table
#> 11 rows x 2 columns
#> $a <int32>
#> $b <double>

(normally this isn't a problem because you should really call head() before as_record_batch_reader(), which communicates the top-k-ness of the query to the ExecPlan rather than relying on abandoning a RecordBatchReader; however, it still should work!)

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@paleolimbot
Copy link
Member Author

paleolimbot commented Nov 2, 2022

@paleolimbot
Copy link
Member Author

This one is just waiting for #14582 before it can be revisited.

@paleolimbot paleolimbot requested a review from thisisnic January 2, 2023 19:24
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@paleolimbot paleolimbot merged commit 63b91cc into apache:master Jan 3, 2023
@paleolimbot paleolimbot deleted the r-exec-reader-head branch January 3, 2023 14:49
@ursabot
Copy link

ursabot commented Jan 4, 2023

Benchmark runs are scheduled for baseline = 139a13e and contender = 63b91cc. 63b91cc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Finished ⬇️2.3% ⬆️0.0%] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 63b91cc1 ec2-t3-xlarge-us-east-2
[Failed] 63b91cc1 test-mac-arm
[Finished] 63b91cc1 ursa-i9-9960x
[Failed] 63b91cc1 ursa-thinkcentre-m75q
[Finished] 139a13e3 ec2-t3-xlarge-us-east-2
[Failed] 139a13e3 test-mac-arm
[Finished] 139a13e3 ursa-i9-9960x
[Failed] 139a13e3 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 4, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
…be read (apache#14518)

This PR enables the following to work:

``` r
library(arrow, warn.conflicts = FALSE)
#> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.

register_scalar_function(
  "times_32",
  function(context, x) x * 32.0,
  int32(),
  float64(),
  auto_convert = TRUE
)

record_batch(a = 1:1000) |> 
  dplyr::mutate(b = times_32(a)) |> 
  as_record_batch_reader() |> 
  head(11) |> 
  as_arrow_table()
#> Table
#> 11 rows x 2 columns
#> $a <int32>
#> $b <double>
```

(normally this isn't a problem because you should really call `head()` before `as_record_batch_reader()`, which communicates the top-k-ness of the query to the ExecPlan rather than relying on abandoning a RecordBatchReader; however, it still should work!)

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants