Skip to content

ARROW-299: Use absolute namespace in macros #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xhochy wants to merge 1 commit into from
Closed

ARROW-299: Use absolute namespace in macros #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cpp/src/arrow/util/logging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ namespace arrow {
#define ARROW_ERROR 2
#define ARROW_FATAL 3

#define ARROW_LOG_INTERNAL(level) arrow::internal::CerrLog(level)
#define ARROW_LOG_INTERNAL(level) ::arrow::internal::CerrLog(level)
#define ARROW_LOG(level) ARROW_LOG_INTERNAL(ARROW_##level)

#define ARROW_CHECK(condition) \
Expand All @@ -47,25 +47,25 @@ namespace arrow {

#define DCHECK(condition) \
while (false) \
arrow::internal::NullLog()
::arrow::internal::NullLog()
#define DCHECK_EQ(val1, val2) \
while (false) \
arrow::internal::NullLog()
::arrow::internal::NullLog()
#define DCHECK_NE(val1, val2) \
while (false) \
arrow::internal::NullLog()
::arrow::internal::NullLog()
#define DCHECK_LE(val1, val2) \
while (false) \
arrow::internal::NullLog()
::arrow::internal::NullLog()
#define DCHECK_LT(val1, val2) \
while (false) \
arrow::internal::NullLog()
::arrow::internal::NullLog()
#define DCHECK_GE(val1, val2) \
while (false) \
arrow::internal::NullLog()
::arrow::internal::NullLog()
#define DCHECK_GT(val1, val2) \
while (false) \
arrow::internal::NullLog()
::arrow::internal::NullLog()

#else
#define ARROW_DFATAL ARROW_FATAL
Expand Down