Skip to content

ARROW-297: Fix Arrow pom for release #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julienledem wants to merge 1 commit into from
Closed

ARROW-297: Fix Arrow pom for release #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions java/format/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
<fbs.version>1.2.0-3f79e055</fbs.version>
<flatc.download.skip>false</flatc.download.skip>
<flatc.executable>${project.build.directory}/flatc-${os.detected.classifier}-${fbs.version}.exe</flatc.executable>
<flatc.generated.files>${project.build.directory}/generated-sources/flatc</flatc.generated.files>
<maven-compiler-plugin.version>3.3</maven-compiler-plugin.version>
<maven-dependency-plugin.version>2.10</maven-dependency-plugin.version>
<os-maven-plugin.version>1.5.0.Final</os-maven-plugin.version>
Expand All @@ -51,7 +52,7 @@
</extensions>

<plugins>
<plugin>
<plugin> <!-- download the flatbuffer compiler -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>${maven-dependency-plugin.version}</version>
Expand Down Expand Up @@ -83,7 +84,7 @@
<artifactId>exec-maven-plugin</artifactId>
<version>1.4.0</version>
<executions>
<execution>
<execution> <!-- make the flatbuffer compiler executable -->
<id>script-chmod</id>
<goals>
<goal>exec</goal>
Expand All @@ -98,7 +99,7 @@
<skip>${flatc.download.skip}</skip>
</configuration>
</execution>
<execution>
<execution> <!-- generate sources by executing the flatbuffer compiler -->
<goals>
<goal>exec</goal>
</goals>
Expand All @@ -108,15 +109,15 @@
<arguments>
<argument>-j</argument>
<argument>-o</argument>
<argument>target/generated-sources/flatc</argument>
<argument>${flatc.generated.files}</argument>
<argument>../../format/Message.fbs</argument>
<argument>../../format/File.fbs</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<plugin> <!-- add the license header to the generated files -->
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
<version>2.3</version>
Expand All @@ -135,26 +136,26 @@
</execution>
</executions>
</plugin>
<plugin>
<plugin> <!-- add generated sources to classpath -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<version>1.9.1</version>
<executions>
<execution>
<id>add-sources-as-resources</id>
<id>add-generated-sources-to-classpath</id>
<phase>generate-sources</phase>
<goals>
<goal>add-source</goal>
</goals>
<configuration>
<sources>
<source>${project.build.directory}/generated-sources</source>
<source>${flatc.generated.files}</source>
</sources>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<plugin> <!-- no checkstyle on the generated code -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
Expand Down
2 changes: 1 addition & 1 deletion java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>14</version>
<version>18</version>
</parent>

<groupId>org.apache.arrow</groupId>
Expand Down