Skip to content

ARROW-17341: [C++] Fix cpu_info.cc build error on musl libc #13819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pitrou merged 1 commit into from
Aug 9, 2022
Merged

ARROW-17341: [C++] Fix cpu_info.cc build error on musl libc #13819

pitrou merged 1 commit into from
Aug 9, 2022

Conversation

@cyb70289
Copy link
Contributor

@cyb70289 cyb70289 commented Aug 9, 2022

No description provided.

cyb70289
cyb70289 commented Aug 9, 2022
View reviewed changes
cpp/src/arrow/util/cpu_info.cc Outdated
Copy link
Contributor Author

@cyb70289 cyb70289 Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Musl libc doesn't define these sysconf flags.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

https://issues.apache.org/jira/browse/ARROW-17341

kou
kou approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou pitrou merged commit 3148884 into apache:master Aug 9, 2022
@cyb70289 cyb70289 deleted the 17341-cpuinfo-sysconf branch August 9, 2022 09:03
@ursabot
Copy link

ursabot commented Aug 9, 2022

Benchmark runs are scheduled for baseline = 709f8f3 and contender = 3148884. 3148884 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.03% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3148884e ec2-t3-xlarge-us-east-2
[Failed] 3148884e test-mac-arm
[Finished] 3148884e ursa-i9-9960x
[Finished] 3148884e ursa-thinkcentre-m75q
[Finished] 709f8f33 ec2-t3-xlarge-us-east-2
[Finished] 709f8f33 test-mac-arm
[Finished] 709f8f33 ursa-i9-9960x
[Finished] 709f8f33 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimport asfimport mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyb70289 @ursabot @kou @pitrou