Skip to content

ARROW-17199: [Java][FlightRPC] Clean up Flight SQL example server #13710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 1 commit into from
Aug 4, 2022
Merged

ARROW-17199: [Java][FlightRPC] Clean up Flight SQL example server #13710

lidavidm merged 1 commit into from
Aug 4, 2022

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Jul 26, 2022

  • Use ARROW-17004 for binding Arrow data to JDBC PreparedStatements
  • Properly return Flight errors for better error messages
  • Don't throw SQLException in the FlightSqlClient

@lidavidm
Copy link
Member Author

lidavidm commented Jul 26, 2022

Depends on #13589

@github-actions
Copy link

github-actions bot commented Jul 26, 2022

https://issues.apache.org/jira/browse/ARROW-17199

@github-actions
Copy link

github-actions bot commented Jul 26, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm lidavidm marked this pull request as ready for review July 26, 2022 17:00
@lidavidm
Copy link
Member Author

lidavidm commented Jul 26, 2022

CC @jduo if you'd like to take a look here

@lidavidm lidavidm mentioned this pull request Aug 2, 2022
Merged
@lidavidm lidavidm merged commit 916417d into apache:master Aug 4, 2022
@ursabot
Copy link

ursabot commented Aug 4, 2022

Benchmark runs are scheduled for baseline = 6d9a6a4 and contender = 916417d. 916417d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.54% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.82% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.43% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 916417da ec2-t3-xlarge-us-east-2
[Finished] 916417da test-mac-arm
[Finished] 916417da ursa-i9-9960x
[Finished] 916417da ursa-thinkcentre-m75q
[Failed] 6d9a6a4a ec2-t3-xlarge-us-east-2
[Finished] 6d9a6a4a test-mac-arm
[Finished] 6d9a6a4a ursa-i9-9960x
[Finished] 6d9a6a4a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimport asfimport mentioned this pull request Aug 4, 2022
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@lidavidm @kou
ARROW-17199: [Java][FlightRPC] Clean up Flight SQL example server (ap…
0d6d711 
…ache#13710)

- Use ARROW-17004 for binding Arrow data to JDBC PreparedStatements
- Properly return Flight errors for better error messages
- Don't throw SQLException in the FlightSqlClient

Authored-by: David Li <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@toddfarmer toddfarmer toddfarmer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm @ursabot @toddfarmer