ARROW-16568: [Java] Enable skipping BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf #13161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lidavidm
changed the title
lidavidm
approved these changes
May 16, 2022
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM.
Do you have a benchmark or any results showing the impact here?
Contributor
Author
|
BTW, We have also changed setSafe() to set() to remove the handleSafe costs. |
lidavidm
changed the title
zhouyuan
pushed a commit
to zhouyuan/arrow
that referenced
this pull request
May 17, 2022
…Bytes of ArrowBuf We have BOUNDS_CHECKING_SKIP in ArrowBuf.setByte or ArrowBuf.getByte, it helps to remove unexpected bounds checks. However, it doesn't exists in ArrowBuf.setBytes or ArrowBuf.getBytes, which makes 10% cpu time cost for checking bounds in our environment. Closes apache#13161 from jackylee-ch/skip_bounds_check_for_set_or_get_bytes Authored-by: stczwd <[email protected]> Signed-off-by: David Li <[email protected]>
zhouyuan
added a commit
to oap-project/arrow
that referenced
this pull request
May 17, 2022
…Bytes of ArrowBuf (#104) We have BOUNDS_CHECKING_SKIP in ArrowBuf.setByte or ArrowBuf.getByte, it helps to remove unexpected bounds checks. However, it doesn't exists in ArrowBuf.setBytes or ArrowBuf.getBytes, which makes 10% cpu time cost for checking bounds in our environment. Closes apache#13161 from jackylee-ch/skip_bounds_check_for_set_or_get_bytes Authored-by: stczwd <[email protected]> Signed-off-by: David Li <[email protected]> Co-authored-by: stczwd <[email protected]>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…Bytes of ArrowBuf We have BOUNDS_CHECKING_SKIP in ArrowBuf.setByte or ArrowBuf.getByte, it helps to remove unexpected bounds checks. However, it doesn't exists in ArrowBuf.setBytes or ArrowBuf.getBytes, which makes 10% cpu time cost for checking bounds in our environment. Closes apache#13161 from jackylee-ch/skip_bounds_check_for_set_or_get_bytes Authored-by: stczwd <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have BOUNDS_CHECKING_SKIP in ArrowBuf.setByte or ArrowBuf.getByte, it helps to remove unexpected bounds checks. However, it doesn't exists in ArrowBuf.setBytes or ArrowBuf.getBytes, which makes 10% cpu time cost for checking bounds in our environment.