Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
2a5a6c2
register 2 bindings (`"package_fun"` as a replacement for `package::f…
dragosmg May 14, 2022
b5bca42
first try with `lubridate_as_datetime` and `lubridate_make_difftime`
dragosmg May 14, 2022
c6e701b
replace `::` in expressions with "_"
dragosmg May 14, 2022
81c17de
remove redundant pipeline and add tests with namespacing
dragosmg May 14, 2022
6ec372d
no piping
dragosmg May 16, 2022
36d9152
update `dplyr-funcs` unit test to reflect new naming convention
dragosmg May 16, 2022
6683913
updated un-registering logic in `register_binding()` + unit tests to …
dragosmg May 16, 2022
2421416
undo changes to `mutate` (no more syntax translation)
dragosmg May 17, 2022
4ca6192
update `register_binding` logic + register the utils bindings
dragosmg May 17, 2022
0577107
add the `::` binding
dragosmg May 17, 2022
a5f5507
replace `_` with `::` for `as_datetime` and `make_difftime`
dragosmg May 17, 2022
a0be5f9
update `register_binding()` tests
dragosmg May 17, 2022
fbc633e
update comment
dragosmg May 17, 2022
380ac60
moved `register_bindings_utils` in `dplyr-funcs.R` + deleted `dplyr-f…
dragosmg May 17, 2022
0a86888
qualifying `string()` with `arrow::` no longer needed and typos (`if6…
dragosmg May 17, 2022
a59c3dd
replace `lubridate::ymd_hms()` with `as.POSIXct()` in the filtering t…
dragosmg May 17, 2022
393529a
batch1 of `nse_funcs` with `pkg::` prefix + unit tests
dragosmg May 18, 2022
f47108f
batch 2 - date/time functionality + undo unary namespacing (it fails …
dragosmg May 18, 2022
6b8402a
updated registrations and unit tests for math functions
dragosmg May 18, 2022
6fe340f
reverse changes in expressions and math tests
dragosmg May 18, 2022
e5ff46f
test no longer needed since we suppor namespacing
dragosmg May 18, 2022
06ad99f
update names and tests for string bindings
dragosmg May 18, 2022
d1917c3
small datetime styling update
dragosmg May 18, 2022
d89cb04
renaming type bindings + unit test update
dragosmg May 18, 2022
dc5902f
undo before merge
dragosmg May 18, 2022
d4bf120
remove before merge
dragosmg May 18, 2022
8e1d11d
clean dyplyr-funcs
dragosmg May 20, 2022
ee29ec3
unit tests for maths functions
dragosmg May 20, 2022
8bed6e9
`lubridate::date`
dragosmg May 20, 2022
4f67040
added unit tests for `base::tolower()` and `base::toupper()`
dragosmg May 20, 2022
1baaea6
`lubridate::date`
dragosmg May 20, 2022
c8a5a4e
`pkg::` prefix for maths functions & `tolower` + `toupper`
dragosmg May 20, 2022
691711e
`abs` and `as.factor`
dragosmg May 20, 2022
fa81467
undo `lubridate::date`
dragosmg May 20, 2022
e28a251
`sign` and `stringi::stri_reverse`
dragosmg May 20, 2022
cc0e86c
`ceiling` and `floor`
dragosmg May 20, 2022
5bb3bb1
`lubridate::date`
dragosmg May 20, 2022
c46efb6
remove `arrow:::` prefix
dragosmg May 20, 2022
ba645c7
point to the correct expression
dragosmg May 23, 2022
1e96d09
`base::strptime()` and `base::strftime()`
dragosmg Jul 4, 2022
91c4b99
undo
dragosmg Jul 4, 2022
8da1365
register namespaced `fast_strptime()`
dragosmg Jul 4, 2022
f534590
math unary bindings
dragosmg Jul 4, 2022
8ffe53c
math functions for ArrowDatum
dragosmg Jul 4, 2022
f61f776
bump ci
dragosmg Jul 4, 2022
5157403
make `filter` fail
dragosmg Jul 6, 2022
163ea2e
remove unrelated change
dragosmg Jul 6, 2022
d757353
removed residual code
dragosmg Jul 6, 2022
8b40099
add namepace qualified tests and remove `pkg::` prefixes from other t…
dragosmg Jul 6, 2022
33a74ea
fallback to `pkg::fun` when the binding does not exist
dragosmg Jul 6, 2022
ecd2a81
use rlang's `%||%` operator
dragosmg Jul 7, 2022
8d2ae15
add namespacing test with `group_by()`
dragosmg Jul 7, 2022
0a02212
remove `tz = "UTC"` (unrelated to the scope of the PR)
dragosmg Jul 7, 2022
7f82028
remove `pkg::` prefixes from test-dplyr-funcs-conditional.R
dragosmg Jul 7, 2022
2e477a3
remove `pkg::` prefixes from test-dplyr-funcs-string.R
dragosmg Jul 7, 2022
8054f96
removed `pkg::` prefixes from test-dplyr-funcs-datetime.R
dragosmg Jul 7, 2022
f9e3a09
remove `pkg::` prefixes from test-dplyr-funcs-type.R
dragosmg Jul 8, 2022
de1b186
remove `pkg::` prefix from test-dplyr-mutate.R
dragosmg Jul 8, 2022
65f1e22
add namespacing support in `summarise()` + unit test
dragosmg Jul 8, 2022
07a1948
lint + `if()` statement
dragosmg Jul 8, 2022
6076918
rename `name` to `unqualified_name` and `fun_name` to `qualified_name`
dragosmg Jul 8, 2022
b1bf744
change
dragosmg Jul 8, 2022
11d5ab1
deal with nested function calls + unit tests for summarise with neste…
dragosmg Jul 8, 2022
7e2f137
`all_funs()` unit tests
dragosmg Jul 8, 2022
52ec424
lint
dragosmg Jul 8, 2022
4ee6884
cleaner test-dplyr-funcs-math.R
dragosmg Jul 8, 2022
c7e82d0
clean-up `Math.ArrowDatum`
dragosmg Jul 8, 2022
ab44391
style dplyr-funcs-datetime.R
dragosmg Jul 8, 2022
33183de
minor improvements
dragosmg Jul 8, 2022
8edc4c8
`mutate` and `transmute` namespacing tests
dragosmg Jul 8, 2022
067c739
register all agg bindings with namespace
dragosmg Jul 8, 2022
48187c3
merge conflict
dragosmg Jul 8, 2022
09e76af
unit tests for `quantile()` with namespacing
dragosmg Jul 8, 2022
66d2ddd
style
dragosmg Jul 8, 2022
d34af62
bump ci
dragosmg Jul 10, 2022
27e43e2
solve `quantile` issue + test for `median()`
dragosmg Jul 11, 2022
eaf1852
split test and skip when RE2 not available
dragosmg Jul 11, 2022
a96879c
minor change to test-dplyr-mutate.R
dragosmg Jul 12, 2022
03152d8
tests for unary and binary string bindings
dragosmg Jul 12, 2022
6125527
removed duplicate tests
dragosmg Jul 12, 2022
b5a8ecf
added tests for namespaced versions of the datetime bindings
dragosmg Jul 12, 2022
0ef791b
test for `base::as.factor()`
dragosmg Jul 12, 2022
73b0390
unit tests for conditional bindings
dragosmg Jul 12, 2022
ca7ae57
unit tests for namespaced date/time bindings - part 1
dragosmg Jul 12, 2022
6c13a4e
unit tests for namespaced date/time bindings - part 2
dragosmg Jul 12, 2022
46247d7
register namespaced `sqrt()` and `exp()` bindings + add math unit tests
dragosmg Jul 12, 2022
6bc27d6
unit test for namespaced `fast_strptime`
dragosmg Jul 12, 2022
e1c202c
bump ci
dragosmg Jul 13, 2022
6e70f0f
bump ci
dragosmg Jul 13, 2022
83a5040
unit tests for namespaced string bindings
dragosmg Jul 14, 2022
b2f81da
unit tests for type bindings
dragosmg Jul 14, 2022
3d9bad9
style
dragosmg Jul 14, 2022
f1dfda4
comment
dragosmg Jul 14, 2022
be7beb8
comment + remove duplicate test
dragosmg Jul 14, 2022
36eb485
unit tests for namespaced aggregating bindings
dragosmg Jul 14, 2022
f115ef6
comments
dragosmg Jul 14, 2022
086529c
comments
dragosmg Jul 14, 2022
8760c34
warn and test for duplicate bindings
dragosmg Jul 14, 2022
e3b1e8f
short paragraph in "Writing bindings"
dragosmg Jul 14, 2022
34bf4b6
lint
dragosmg Jul 14, 2022
46f6f6a
remove `arrow:::` from the `all_funs()` test
dragosmg Jul 14, 2022
7cd221b
typo
dragosmg Jul 14, 2022
b235617
simplify `stats::quantile` if statement
dragosmg Jul 14, 2022
d05ac0c
keep a single `dplyr::case_when()` test
dragosmg Jul 14, 2022
707fbd2
simplify the registration of the `"::"` binding and the `register_bin…
dragosmg Jul 14, 2022
75f3246
typo
dragosmg Jul 14, 2022
4a3a8b7
change to a `compare_dplyr_binding()` test for `dplyr::between()`
dragosmg Jul 14, 2022
d68d173
shrink datetime unit tests
dragosmg Jul 14, 2022
627b520
shrink type unit tests
dragosmg Jul 14, 2022
0085cd5
shrink summarise unit tests
dragosmg Jul 14, 2022
0c74e87
lints
dragosmg Jul 14, 2022
5368c39
shrink mutate unit tests
dragosmg Jul 14, 2022
62786ce
shrink string unit tests
dragosmg Jul 15, 2022
0c7d599
shrink math unit tests
dragosmg Jul 15, 2022
f6ba7b4
removed empty line
dragosmg Jul 15, 2022
e8fcc5b
trim string test file
dragosmg Jul 15, 2022
4413eab
trim conditional unit tests file
dragosmg Jul 15, 2022
9b93ff5
improved comments
dragosmg Jul 15, 2022
0b54a28
remove the ability to remove a binding + typo
dragosmg Jul 15, 2022
379589f
removed duplicate test
dragosmg Jul 15, 2022
aba6564
some more trimming
dragosmg Jul 15, 2022
642c23e
simplify `wrap_hash_quantile()`
dragosmg Jul 15, 2022
bce4c69
remove duplicate helper data
dragosmg Jul 15, 2022
fb7002e
trimmed condition for binding registration
dragosmg Jul 15, 2022
cbf6401
simplify `register_binding()` further
dragosmg Jul 15, 2022
5f468f6
use `sub()` with `{+}`
dragosmg Jul 15, 2022
d6b7601
test `transmute()` defusing the dots with `stringr::str_squish()`
dragosmg Jul 15, 2022
334c810
lint
dragosmg Jul 15, 2022
ac316ee
add `tbl` back in
dragosmg Jul 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions r/R/arrow-datum.R
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ Ops.ArrowDatum <- function(e1, e2) {
#' @export
Math.ArrowDatum <- function(x, ..., base = exp(1), digits = 0) {
switch(.Generic,
abs = ,
abs = eval_array_expression("abs_checked", x),
ceiling = eval_array_expression("ceil", x),
sign = ,
floor = ,
ceiling = ,
trunc = ,
acos = ,
asin = ,
Expand Down
20 changes: 10 additions & 10 deletions r/R/dplyr-datetime-helpers.R
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ check_time_locale <- function(locale = Sys.getlocale("LC_TIME")) {
}

.helpers_function_map <- list(
"dminutes" = list(60, "s"),
"dhours" = list(3600, "s"),
"ddays" = list(86400, "s"),
"dweeks" = list(604800, "s"),
"dmonths" = list(2629800, "s"),
"dyears" = list(31557600, "s"),
"dseconds" = list(1, "s"),
"dmilliseconds" = list(1, "ms"),
"dmicroseconds" = list(1, "us"),
"dnanoseconds" = list(1, "ns")
"lubridate::dminutes" = list(60, "s"),
"lubridate::dhours" = list(3600, "s"),
"lubridate::ddays" = list(86400, "s"),
"lubridate::dweeks" = list(604800, "s"),
"lubridate::dmonths" = list(2629800, "s"),
"lubridate::dyears" = list(31557600, "s"),
"lubridate::dseconds" = list(1, "s"),
"lubridate::dmilliseconds" = list(1, "ms"),
"lubridate::dmicroseconds" = list(1, "us"),
"lubridate::dnanoseconds" = list(1, "ns")
)
make_duration <- function(x, unit) {
# TODO(ARROW-15862): remove first cast to int64
Expand Down
8 changes: 4 additions & 4 deletions r/R/dplyr-funcs-conditional.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# under the License.

register_bindings_conditional <- function() {
register_binding("coalesce", function(...) {
register_binding("dplyr::coalesce", function(...) {
args <- list2(...)
if (length(args) < 1) {
abort("At least one argument must be supplied to coalesce()")
Expand Down Expand Up @@ -60,14 +60,14 @@ register_bindings_conditional <- function() {
build_expr("if_else", condition, true, false)
}

register_binding("if_else", if_else_binding)
register_binding("dplyr::if_else", if_else_binding)

# Although base R ifelse allows `yes` and `no` to be different classes
register_binding("ifelse", function(test, yes, no) {
register_binding("base::ifelse", function(test, yes, no) {
if_else_binding(condition = test, true = yes, false = no)
})

register_binding("case_when", function(...) {
register_binding("dplyr::case_when", function(...) {
formulas <- list2(...)
n <- length(formulas)
if (n == 0) {
Expand Down
Loading