-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-16525: [C++] Tee node not properly marking node finished #13117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16525: [C++] Tee node not properly marking node finished #13117
Conversation
…tee node where it was not properly marking itself finished
|
|
|
CC @rtpsw please take a look |
|
Thanks for doing this, @westonpace ! |
|
LGTM. Just a few small suggestions. |
…or working with arrow::compute::Declaration. Minor cleanup of some error messages
rtpsw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant tests are failing. Need to take a look.
…or checking. The first node should be allowed to have multiple inputs since we don't need to recurse any further
|
Current failures don't look relevant to this PR. |
|
Benchmark runs are scheduled for baseline = 940ab93 and contender = d040fb5. d040fb5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.