Skip to content

Conversation

@westonpace
Copy link
Member

No description provided.

…tee node where it was not properly marking itself finished
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@westonpace
Copy link
Member Author

CC @rtpsw please take a look

@rtpsw
Copy link
Contributor

rtpsw commented May 11, 2022

Thanks for doing this, @westonpace !

@rtpsw
Copy link
Contributor

rtpsw commented May 11, 2022

LGTM. Just a few small suggestions.

…or working with arrow::compute::Declaration. Minor cleanup of some error messages
Copy link
Contributor

@rtpsw rtpsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant tests are failing. Need to take a look.

…or checking. The first node should be allowed to have multiple inputs since we don't need to recurse any further
@rtpsw
Copy link
Contributor

rtpsw commented May 12, 2022

Current failures don't look relevant to this PR.

@westonpace westonpace requested a review from bkietz May 13, 2022 21:27
@bkietz bkietz closed this in d040fb5 May 16, 2022
@ursabot
Copy link

ursabot commented May 16, 2022

Benchmark runs are scheduled for baseline = 940ab93 and contender = d040fb5. d040fb5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.43% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.28% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d040fb56 ec2-t3-xlarge-us-east-2
[Finished] d040fb56 test-mac-arm
[Finished] d040fb56 ursa-i9-9960x
[Finished] d040fb56 ursa-thinkcentre-m75q
[Finished] 940ab93a ec2-t3-xlarge-us-east-2
[Finished] 940ab93a test-mac-arm
[Finished] 940ab93a ursa-i9-9960x
[Finished] 940ab93a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants