ARROW-16248: [C++][FS] Actually enable GCS support in FileSystemFromUri() #12932
Conversation
|
Cc: @coryan |
|
|
pitrou
changed the title
| #cmakedefine ARROW_IPC | ||
| #cmakedefine ARROW_JSON | ||
|
|
||
| #cmakedefine ARROW_GCS |
There was a problem hiding this comment.
If we don't have this, ARROW_GCS macro isn't defined even when we build Apache Arrow with -DARROW_GCS=ON.
If ARROW_GCS macro isn't defined, we always get a "Got GCS URI but Arrow compiled without GCS support" error even when we build Apache Arrow with -DARROW_GCS=ON.
There was a problem hiding this comment.
Hmm, I see, does this mean there are no tests for this?
There was a problem hiding this comment.
My PR also covers this
pitrou
changed the title
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Thanks. I guess I missed that. LGTM.
|
I would prefer not to merge this separately because I think without the python binding PR users are going to get unexpected results when reading existing datasets |
|
For the record, @emkornfield 's PR is #12763. |
|
OK. I withdraw this in favor of #12763. |
4 participants
Define the
ARROW_GCSmacro, otherwise the relevant code wasn't compiled.