Skip to content

ARROW-1134: [C++] Support for C++/CLI compilation, add NULLPTR define to avoid using nullptr in public headers #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesm wants to merge 2 commits into from
Closed

ARROW-1134: [C++] Support for C++/CLI compilation, add NULLPTR define to avoid using nullptr in public headers #1228

wesm wants to merge 2 commits into from

Conversation

@wesm
Copy link
Member

@wesm wesm commented Oct 21, 2017

cc @TobyShaw. Can you test this?

Close #1098

@wesm
Add NULLPTR macro to avoid using nullptr in public headers for C++/CL…
a51dd88 
…I users

Change-Id: Id8ef2be3f293a5fbb1cc6e5b792b25b9391bcf6b
@wesm wesm mentioned this pull request Oct 23, 2017
Closed
@wesm
Copy link
Member Author

wesm commented Oct 23, 2017 •
edited
Loading

We should probably have some kind of linting script to check that nullptr or <mutex> does not creep into a public header. I could write some kind of Python script for this

@wesm
Only define NULLPTR if not already defined
bf18158 
Change-Id: I150dd146b0186afaedc4f9796825f846882f19b0
@wesm
Copy link
Member Author

wesm commented Oct 24, 2017

@xhochy @cpcloud I would suggest we should merge this and wait for more feedback from C++/CLI users

@wesm
Copy link
Member Author

wesm commented Oct 24, 2017

In the meantime we'll need to add a linting script so that this work does not get undone by a future patch

@cpcloud
Copy link
Contributor

cpcloud commented Oct 25, 2017

+1 LGTM

@wesm wesm closed this in ecb7605 Oct 25, 2017
@wesm wesm deleted the ARROW-1134 branch October 25, 2017 19:27
@asfimport asfimport mentioned this pull request Oct 25, 2017
Closed
@kou kou mentioned this pull request Feb 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wesm @cpcloud