ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown #12037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flight server spawns a background thread that reads from a pipe, then shuts down the server. (The pipe is written to by a signal handler). On normal shutdown, the server would close the pipe, then join the background thread, leading to a race: the background thread might read from the pipe again, getting a "bad fd" error. The fix is simple; just join the thread before closing the pipe.