Skip to content

ARROW-14741: [C++] Add support for RecordBatchReader in CSV writer #11899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahadnagy wants to merge 2 commits into from
Closed

ARROW-14741: [C++] Add support for RecordBatchReader in CSV writer #11899

ahadnagy wants to merge 2 commits into from

Conversation

@ahadnagy
Copy link
Contributor

@ahadnagy ahadnagy commented Dec 8, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

https://issues.apache.org/jira/browse/ARROW-14741

lidavidm
lidavidm approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

@thisisnic just to confirm, is this the function you were looking to use from the R side?

@thisisnic
Copy link
Member

thisisnic commented Dec 8, 2021

Thanks, this looks good to me.

@thisisnic just to confirm, is this the function you were looking to use from the R side?

Yeah, I think this is what we were after. Thanks!

@lidavidm lidavidm closed this in afa5d95 Dec 8, 2021
@ursabot
Copy link

ursabot commented Dec 8, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = d3bf0f6 and contender = afa5d95. afa5d95 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimport asfimport mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahadnagy @thisisnic @ursabot @lidavidm