ARROW-13989: [C++] Add support for month-day-nano interval to compute functions #11525
Conversation
|
|
There was a problem hiding this comment.
Out of curiosity, why is_interval_type here while IfElseFunctor only allows month-day-nano intervals?
There was a problem hiding this comment.
This helper is used by coalesce/choose/case_when so this is part of adding support for all of those functions.
if_else should support all the interval types. It uses GenerateTypeAgnosticPrimitive, so DayTime and Month intervals are handled as integers.
There was a problem hiding this comment.
Slightly unrelated to this PR, but it seems that amongst the ReplaceWithMask tests, the mask is always of the form (regex) true* (false|null)*, meaning that the replacement index is always trivially equal to the source index. Is that deliberate?
There was a problem hiding this comment.
It's not deliberate. I'll update the tests to avoid this.
|
Benchmark runs are scheduled for baseline = 140b0b2 and contender = f4dd806. f4dd806 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
No description provided.