Skip to content

ARROW-244: Some global APIs of IPC module should be visible to the outside #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jihoonson wants to merge 2 commits into from
Closed

ARROW-244: Some global APIs of IPC module should be visible to the outside #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2da5466
Make some APIs of IPC module visible
jihoonson Jul 27, 2016
51d9a87
Make line length shorter than 90
jihoonson Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cpp/src/arrow/ipc/adapter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
#include <cstdint>
#include <memory>

#include "arrow/util/visibility.h"

namespace arrow {

class Array;
Expand Down Expand Up @@ -54,20 +56,21 @@ constexpr int kMaxIpcRecursionDepth = 64;
//
// Finally, the memory offset to the start of the metadata / data header is
// returned in an out-variable
Status WriteRowBatch(MemorySource* dst, const RowBatch* batch, int64_t position,
int64_t* header_offset, int max_recursion_depth = kMaxIpcRecursionDepth);
ARROW_EXPORT Status WriteRowBatch(MemorySource* dst, const RowBatch* batch,
int64_t position, int64_t* header_offset,
int max_recursion_depth = kMaxIpcRecursionDepth);

// int64_t GetRowBatchMetadata(const RowBatch* batch);

// Compute the precise number of bytes needed in a contiguous memory segment to
// write the row batch. This involves generating the complete serialized
// Flatbuffers metadata.
Status GetRowBatchSize(const RowBatch* batch, int64_t* size);
ARROW_EXPORT Status GetRowBatchSize(const RowBatch* batch, int64_t* size);

// ----------------------------------------------------------------------
// "Read" path; does not copy data if the MemorySource does not

class RowBatchReader {
class ARROW_EXPORT RowBatchReader {
public:
static Status Open(
MemorySource* source, int64_t position, std::shared_ptr<RowBatchReader>* out);
Expand Down
5 changes: 3 additions & 2 deletions cpp/src/arrow/ipc/memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <string>

#include "arrow/util/macros.h"
#include "arrow/util/visibility.h"

namespace arrow {

Expand Down Expand Up @@ -69,7 +70,7 @@ class BufferOutputStream : public OutputStream {
int64_t position_;
};

class MemorySource {
class ARROW_EXPORT MemorySource {
public:
// Indicates the access permissions of the memory source
enum AccessMode { READ_ONLY, READ_WRITE };
Expand Down Expand Up @@ -100,7 +101,7 @@ class MemorySource {
};

// A memory source that uses memory-mapped files for memory interactions
class MemoryMappedSource : public MemorySource {
class ARROW_EXPORT MemoryMappedSource : public MemorySource {
public:
static Status Open(const std::string& path, AccessMode access_mode,
std::shared_ptr<MemoryMappedSource>* out);
Expand Down