Skip to content

ARROW-13200: [R] Add binding for case_when() #10737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianmcook wants to merge 8 commits into from
Closed

ARROW-13200: [R] Add binding for case_when() #10737

ianmcook wants to merge 8 commits into from

Conversation

@ianmcook
Copy link
Member

@ianmcook ianmcook commented Jul 17, 2021 •
edited
Loading

Adds support for case_when() in dplyr verbs. I followed the example of dbplyr::case_when(), which is much simpler and more self-contained than dplyr::case_when().

@github-actions
Copy link

github-actions bot commented Jul 17, 2021

https://issues.apache.org/jira/browse/ARROW-13200

@nealrichardson nealrichardson self-requested a review July 17, 2021 14:52
@ianmcook ianmcook marked this pull request as ready for review July 17, 2021 17:14
@ianmcook
Copy link
Member Author

ianmcook commented Jul 17, 2021

Let's merge #10724 before we merge this. I will rebase and resolve the conflicts after #10724 is merged.

@ianmcook
Copy link
Member Author

ianmcook commented Jul 17, 2021

@github-actions crossbow submit test-r-without-arrow test-r-minimal-build

@github-actions
Copy link

github-actions bot commented Jul 17, 2021

Revision: db7c0d267b6dbc1c35d29d4d08aafcd7f99e2334

Submitted crossbow builds: ursacomputing/crossbow @ actions-610

Task Status
test-r-minimal-build Azure
test-r-without-arrow Azure

ianmcook
ianmcook commented Jul 17, 2021
View reviewed changes
ianmcook
ianmcook commented Jul 17, 2021
View reviewed changes
nealrichardson
nealrichardson reviewed Jul 17, 2021
View reviewed changes
nealrichardson
nealrichardson reviewed Jul 17, 2021
View reviewed changes
@nealrichardson
Copy link
Member

nealrichardson commented Jul 17, 2021

I've merged the news PR, so after you rebase please add a bullet in the new dplyr functions section for this (noting any type limitations) and also note if_else there too (which I think doesn't have those same type limitations?)

nealrichardson
nealrichardson reviewed Jul 17, 2021
View reviewed changes
nealrichardson
nealrichardson approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ianmcook ianmcook closed this in b32e0bf Jul 18, 2021
@asfimport asfimport mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ianmcook @nealrichardson