Skip to content

ARROW-13220: [C++] Implement 'choose' function #10642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lidavidm wants to merge 3 commits into from
Closed

ARROW-13220: [C++] Implement 'choose' function #10642

lidavidm wants to merge 3 commits into from

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Jul 1, 2021

Also makes two changes:

  • MakeArrayFromScalar now works with Decimal256 and FixedSizeBinaryType
  • VarArgs(min_args=N) for N>1 now works (before different assertions/runtime checks would trigger). Though, might it make sense to update KernelSignature to reflect min_args?

@lidavidm lidavidm changed the title ARROW-13064: [C++] Implement 'choose' function ARROW-13220: [C++] Implement 'choose' function Jul 2, 2021
@github-actions
Copy link

github-actions bot commented Jul 2, 2021

https://issues.apache.org/jira/browse/ARROW-13220

@apache apache deleted a comment from github-actions bot Jul 2, 2021
@lidavidm lidavidm mentioned this pull request Jul 2, 2021
Closed
@lidavidm lidavidm force-pushed the arrow-13220 branch 2 times, most recently from f419cf1 to 9fdbdc0 Compare July 13, 2021 13:22
@lidavidm
Copy link
Member Author

lidavidm commented Jul 13, 2021

@ursabot please benchmark lang=C++

@ursabot
Copy link

ursabot commented Jul 13, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = ca50cd1 and contender = 3c1182c9bdaf656c2ef1c0311e5078f45b87eb78. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2 (mimalloc)
[Skipped ⚠️ Only ['Python', 'R'] langs are supported on ursa-i9-9960x] ursa-i9-9960x (mimalloc)
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q (mimalloc)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@lidavidm lidavidm force-pushed the arrow-13220 branch 2 times, most recently from 80858c2 to e74efb6 Compare July 14, 2021 15:48
@lidavidm
Copy link
Member Author

lidavidm commented Jul 16, 2021

This needs a lot of merge conflict resolving, so moving to draft for now until #10608 is also merged.

@lidavidm lidavidm marked this pull request as draft July 16, 2021 15:55
@lidavidm lidavidm marked this pull request as ready for review July 19, 2021 20:26
pitrou
pitrou requested changes Jul 27, 2021
View reviewed changes
@pitrou pitrou closed this in af75883 Aug 4, 2021
This was referenced Jul 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm @ursabot @pitrou