Skip to content

[CI][Dev] Fix shellcheck errors in the ci/scripts/integration_arrow.sh #47088

@hiroyuki-sato

Description

@hiroyuki-sato

Describe the enhancement requested

This is the sub issue #44748.

  • SC2046: Quote this to prevent word splitting.
  • SC2086: Double quote to prevent globbing and word splitting.
  • SC2102: Ranges can only match single chars (mentioned due to duplicates).
  • SC2223: This default assignment may cause DoS due to globbing. Quote it.
ci/scripts/integration_arrow.sh

In ci/scripts/integration_arrow.sh line 27:
: ${ARROW_INTEGRATION_CPP:=ON}
  ^--------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/integration_arrow.sh line 28:
: ${ARROW_INTEGRATION_CSHARP:=ON}
  ^-----------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/integration_arrow.sh line 30:
: ${ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS:=cpp,csharp}
  ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/integration_arrow.sh line 33:
. ${arrow_dir}/ci/scripts/util_log.sh
  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
. "${arrow_dir}"/ci/scripts/util_log.sh


In ci/scripts/integration_arrow.sh line 36:
pip install -e $arrow_dir/dev/archery[integration]
               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^-----------^ SC2102 (info): Ranges can only match single chars (mentioned due to duplicates).

Did you mean:
pip install -e "$arrow_dir"/dev/archery[integration]


In ci/scripts/integration_arrow.sh line 66:
    --with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \
               ^-- SC2046 (warning): Quote this to prevent word splitting.


In ci/scripts/integration_arrow.sh line 67:
    --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \
                  ^-- SC2046 (warning): Quote this to prevent word splitting.


In ci/scripts/integration_arrow.sh line 68:
    --gold-dirs=$gold_dir/0.14.1 \
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    --gold-dirs="$gold_dir"/0.14.1 \


In ci/scripts/integration_arrow.sh line 69:
    --gold-dirs=$gold_dir/0.17.1 \
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    --gold-dirs="$gold_dir"/0.17.1 \


In ci/scripts/integration_arrow.sh line 70:
    --gold-dirs=$gold_dir/1.0.0-bigendian \
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    --gold-dirs="$gold_dir"/1.0.0-bigendian \


In ci/scripts/integration_arrow.sh line 71:
    --gold-dirs=$gold_dir/1.0.0-littleendian \
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    --gold-dirs="$gold_dir"/1.0.0-littleendian \


In ci/scripts/integration_arrow.sh line 72:
    --gold-dirs=$gold_dir/2.0.0-compression \
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    --gold-dirs="$gold_dir"/2.0.0-compression \


In ci/scripts/integration_arrow.sh line 73:
    --gold-dirs=$gold_dir/4.0.0-shareddict \
                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    --gold-dirs="$gold_dir"/4.0.0-shareddict \

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2102 -- Ranges can only match single char...

Component(s)

Continuous Integration

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions