[C++] Enable arrow::EqualOptions::use_atol_ for arrow::Array, arrow::Scalar, arrow::Tensor, and arrow::SparseTensor.

[andishgar]

Describe the enhancement requested

During this pull request, arrow::EqualOptions::use_atol_ was introduced. This option should be enabled for comparisons involving arrow::Array, arrow::Scalar, arrow::Tensor, and arrow::SparseTensor types.

Component(s)

C++

[andishgar]

@kou I have a question regarding arrow::{Sparse,}Tensor :
Should I consider the following codes forarrow::Tensorand arrow::SparseTensor a bug, as arrow::EqualOptions::atol_ is not included in the comparison?

arrow/cpp/src/arrow/compare.cc

Lines 1280 to 1281 in 494d0e3

	VisitFloatingEquality<c_type>(opts, /*floating_approximate=*/false,
	std::move(visitor));

arrow/cpp/src/arrow/compare.cc

Lines 1360 to 1375 in 494d0e3

	for (int64_t i = 0; i < length; ++i) {
	const auto left = left_data[i];
	const auto right = right_data[i];
	if (left != right && !(std::isnan(left) && std::isnan(right))) {
	return false;
	}
	}
	} else {
	for (int64_t i = 0; i < length; ++i) {
	if (left_data[i] != right_data[i]) {
	return false;
	}
	}
	}
	return true;
	}

I mean such an assertion, it has passed

TEST(Tensor,FloatComparasion) {
  std::vector<double> v1 = {0.5};
  std::vector<double> v2 = {0.5001};
  std::shared_ptr<Buffer> b1 = Buffer::Wrap(v1);
  std::shared_ptr<Buffer> b2 = Buffer::Wrap(v2);
  NumericTensor<DoubleType> t1(b1, {1, 1});
  NumericTensor<DoubleType> t2(b2, {1, 1});
  auto st1 = SparseCSCMatrix::Make(t1).ValueOrDie();
  auto st2 = SparseCSCMatrix::Make(t2).ValueOrDie();
  ASSERT_FALSE(t1.Equals(t2, EqualOptions::Defaults().atol(1e-3)));
  ASSERT_FALSE(st1->Equals(*st2, EqualOptions::Defaults().atol(1e-3)));
}

[andishgar]

take

[pitrou]

Should I consider the following codes forarrow::Tensorand arrow::SparseTensor a bug, as arrow::EqualOptions::atol_ is not included in the comparison?

Yes, it's certainly a bug. You don't necessarily have to care about it.

[andishgar]

Thank you for the clarification, @pitrou. I will open a separate issue for it

[kou]

Issue resolved by pull request 46779
#46779