[R] Implement bindings for lubridate's floor_date, ceiling_date, and round_date

[asfimport]

Reporter: Nicola Crane / @thisisnic
Assignee: Danielle Navarro / @djnavarro
Watchers: Rok Mihevc / @rok

Related issues:

• [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week (is blocked by)
• [R] How to round the timestamps in a mutate statement? (is duplicated by)
• [R] How to round the timestamps in a mutate statement? (relates to)
• [C++] Implement floor/ceil/round for temporal objects (requires)
• [R] Binding for lubridate::qday (is required by)

PRs and other links:

• GitHub Pull Request #12154
• GitHub Pull Request #12657

_{Note: This issue was originally created as ARROW-14821. Please see the migration documentation for further details.}

[asfimport]

Rok Mihevc / @rok:
ARROW-14822 is done so this can now be tackled.

[asfimport]

Danielle Navarro / @djnavarro:
I'd be happy to make an attempt at this one!

[asfimport]

Nicola Crane / @thisisnic:
@djnavarro Awesome!  Give us a shout if you need anything - also, if you have time (but feel free to skip it as like, it's your first week and I'm sure you're busy!), would you mind taking a look at the new docs we have on writing bindings and giving some feedback on them?  They're at a sort of "here's my first attempt to get something merged to iterate on later" state, so totally fine if the feedback is "change everything!"

The nightly build of the docs are here: https://ursalabs.org/arrow-r-nightly/articles/developers/bindings.html

[asfimport]

Rok Mihevc / @rok:
@djnavarro nice! :)
Please note c++ currently doesn't accept frequency strings and there's an open discussion about that here: ARROW-15250.

[asfimport]

Rok Mihevc / @rok:
Oh and another thing - c++ currently only tests round/ceil/floor for timestamps but it should also work for dates and times. So this ticket could be expanded to do date/time/timestamp or split into more tickets.

[asfimport]

Danielle Navarro / @djnavarro:
@thisisnic I'll definitely take a look! I may not have any useful feedback until I've managed to orient myself, but I'll keep notes on my process as a first time contributor and see if I notice pain points or think of anything :)

@rok Thanks!

[asfimport]

Danielle Navarro / @djnavarro:
Okay there's a first pass at this here: #12154

It's still missing some of key functionality from the lubridate equivalents. The two that are bugging me are (1) it doesn't support the week_start argument, so any attempt to round to the nearest week will assume that the week starts on Thursday, and (2) I'm having some difficulties with how timezones are handled, and not sure if the problem is in my code or if the C++ round_temporal function needs something extra?

In any case, I think it's at the point where I'd benefit from someone taking a look, in case I am doing something terribly wrong :)

[asfimport]

Dragoș Moldovan-Grünfeld / @dragosmg:
@rok :D has just resolved the C++ issue blocking this.

[asfimport]

Antoine Pitrou / @pitrou:
Issue resolved by pull request 12657
#12657

[asfimport]

Todd Farmer / @toddfarmer:
Still has open second PR: #12154 so reopening.

[asfimport]

Neal Richardson / @nealrichardson:
Issue resolved by pull request 12154
#12154